Use readonly class annotation where possible
#593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ocramius
requested changes
Oct 28, 2024
| @@ -43,14 +43,13 @@ | |||
|
|
|||
| use function sprintf; | |||
|
|
|||
| /** @immutable */ | |||
| final class SessionMiddleware implements MiddlewareInterface | |||
| final readonly class SessionMiddleware implements MiddlewareInterface | |||
There was a problem hiding this comment.
Careful: readonly != @immutable. @immutable implies readonly + no side-effects.
There was a problem hiding this comment.
This is a sad naming choice from Psalm that hunted me since its introduction.
I know no other tool that treats readonly differently from @immutable
There was a problem hiding this comment.
I also don't know of other tools that enforce immutability right now, which is why I keep sticking to psalm (for now) :P
There was a problem hiding this comment.
Annotation restored with the more specific @psalm-immutable name
Ocramius
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.