Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop vimeo/psalm, add phpstan/phpstan #592

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

Slamdunk
Copy link
Member

Needed for #586

As of today vimeo/psalm is lacking behind in supporting the updated ecosystem we need to stay up-to-date ourself.

@Slamdunk Slamdunk added enhancement dependencies Pull requests that update a dependency file labels Oct 28, 2024
@Slamdunk Slamdunk added this to the 9.2.0 milestone Oct 28, 2024
@Slamdunk Slamdunk force-pushed the from_psalm_to_phpstan branch 2 times, most recently from d6c3d7e to b1e3f58 Compare October 28, 2024 14:10
@Slamdunk Slamdunk merged commit cc46e64 into psr7-sessions:9.2.x Oct 28, 2024
10 checks passed
@Slamdunk Slamdunk deleted the from_psalm_to_phpstan branch October 28, 2024 14:12
@Ocramius
Copy link
Member

Disagreeing here: vimeo/psalm has @pure and @immutable semantics that are hugely relevant for this repo, even more than version support, IMO.

If the problem is version updates, then I suggest moving vimeo/psalm to tools/, and running it off PHP 8.3, for now.

@Slamdunk
Copy link
Member Author

So yes, I understand the relevance of the @psalm-immutable annotation.

As someone who maintain dozens of packages and all the related renovate-bot failures, the phar bundle of PHPStan is a huge win for me.
I understand the tecnical solution of the tools/ directory, but it's yet another PITA compared to a direct require-dev dependency.

I want this package to be healthy, yet I won't fulfill this specific request from you, maintenance is exhausting and I need it to be as smooth as possible.

@Ocramius
Copy link
Member

That is fair, just beware that @immutable is the main-main-main reason why Psalm still has an extremely important edge over PHPStan.

You aren't doing anything scary here, type-wise, just beware that there will be regressions in immutability in future patches, even if just by accident.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants