Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to PHPUnit 10 #561

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Update to PHPUnit 10 #561

merged 1 commit into from
Oct 28, 2024

Conversation

Slamdunk
Copy link
Member

No description provided.

<files psalm-version="5.7.7@e028ba46ba0d7f9a78bc3201c251e137383e145f">
<file src="test/StoragelessTest/Session/LazySessionTest.php">
<InvalidFunctionCall>
<code><![CDATA[($this->sessionLoader)()]]></code>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, when I move from:

    /** @var MakeSession&MockObject */
    private MakeSession $sessionLoader;

to

    /** @var MakeSession&MockObject */
    private MakeSession&MockObject $sessionLoader;

Tests of course pass, and PSalm doesn't need the baseline.

But then phpcbf removed the DocBlock, and for some unbeknownst reason, PSalm breaks 😢

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prioritize psalm over phocbf here: we can tell phpcbf to shut up here, and remove the baseline instead.

Rationale: this project should remain baseline -less.

<files psalm-version="5.7.7@e028ba46ba0d7f9a78bc3201c251e137383e145f">
<file src="test/StoragelessTest/Session/LazySessionTest.php">
<InvalidFunctionCall>
<code><![CDATA[($this->sessionLoader)()]]></code>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prioritize psalm over phocbf here: we can tell phpcbf to shut up here, and remove the baseline instead.

Rationale: this project should remain baseline -less.

@Ocramius Ocramius added enhancement dependencies Pull requests that update a dependency file labels Feb 26, 2023
@Ocramius Ocramius added this to the 8.16.0 milestone Feb 26, 2023
@Ocramius Ocramius changed the base branch from 8.15.x to 8.16.x February 26, 2023 13:23
@Slamdunk
Copy link
Member Author

Slamdunk commented Feb 26, 2023

@Ocramius I bet the infection fail is related to PHPUnit 10 completely dropped phpdbg support, and laminas-continuous-integration-action not installing PCOV nor xDebug, but I'm not aware on how exactly laminas-ci works.

Can you tell me where to look to figure this out?

@Ocramius
Copy link
Member

That's on me to do: laminas/laminas-continuous-integration-action#130

@Ocramius Ocramius removed this from the 8.16.0 milestone Mar 28, 2023
@Slamdunk Slamdunk changed the base branch from 8.16.x to 9.2.x October 28, 2024 13:39
@Slamdunk Slamdunk added this to the 9.2.0 milestone Oct 28, 2024
@Slamdunk Slamdunk merged commit df32833 into psr7-sessions:9.2.x Oct 28, 2024
10 checks passed
@Slamdunk Slamdunk deleted the phpunit_10 branch October 28, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants