Merge pull request #580 from Slamdunk/clone_configs

Configuration: lets clone third-party config objects
psr7-sessions · Jul 26, 2023 · eb78151 · eb78151
2 parents 3ce8459 + 06cc1a3
commit eb78151
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/Storageless/Http/Configuration.php b/src/Storageless/Http/Configuration.php
@@ -98,7 +98,7 @@ public function getClientFingerprintConfiguration(): FingerprintConfig
     public function withJwtConfiguration(JwtConfig $jwtConfiguration): self
     {
         $new                   = clone $this;
-        $new->jwtConfiguration = $jwtConfiguration;
+        $new->jwtConfiguration = clone $jwtConfiguration;
 
         return $new;
     }

diff --git a/test/StoragelessTest/Http/ConfigurationTest.php b/test/StoragelessTest/Http/ConfigurationTest.php
@@ -94,7 +94,7 @@ public function testImmutability(): void
         $jwtConfig   = clone $this->jwtConfig;
         $rightConfig = $leftConfig->withJwtConfiguration($jwtConfig);
         self::assertNotSame($leftConfig, $rightConfig);
-        self::assertSame($jwtConfig, $rightConfig->getJwtConfiguration());
+        self::assertNotSame($jwtConfig, $rightConfig->getJwtConfiguration());
 
         $clock      = FrozenClock::fromUTC();
         $leftConfig = $rightConfig->withClock($clock);