Configuration: mutable dependencies shouldn't be cloned

psr7-sessions · Jul 25, 2023 · 83a3134 · 83a3134
1 parent d5ecad4
commit 83a3134
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/Storageless/Http/Configuration.php b/src/Storageless/Http/Configuration.php
@@ -98,15 +98,15 @@ public function getClientFingerprintConfiguration(): FingerprintConfig
     public function withJwtConfiguration(JwtConfig $jwtConfiguration): self
     {
         $new                   = clone $this;
-        $new->jwtConfiguration = clone $jwtConfiguration;
+        $new->jwtConfiguration = $jwtConfiguration;
 
         return $new;
     }
 
     public function withClock(Clock $clock): self
     {
         $new        = clone $this;
-        $new->clock = clone $clock;
+        $new->clock = $clock;
 
         return $new;
     }

diff --git a/test/StoragelessTest/Http/ConfigurationTest.php b/test/StoragelessTest/Http/ConfigurationTest.php
@@ -94,12 +94,12 @@ public function testImmutability(): void
         $jwtConfig   = clone $this->jwtConfig;
         $rightConfig = $leftConfig->withJwtConfiguration($jwtConfig);
         self::assertNotSame($leftConfig, $rightConfig);
-        self::assertNotSame($jwtConfig, $rightConfig->getJwtConfiguration());
+        self::assertSame($jwtConfig, $rightConfig->getJwtConfiguration());
 
         $clock      = FrozenClock::fromUTC();
         $leftConfig = $rightConfig->withClock($clock);
         self::assertNotSame($leftConfig, $rightConfig);
-        self::assertNotSame($clock, $leftConfig->getClock());
+        self::assertSame($clock, $leftConfig->getClock());
 
         $cookie      = SetCookie::create('foo');
         $rightConfig = $leftConfig->withCookie($cookie);