Skip to content
This repository has been archived by the owner on Oct 31, 2022. It is now read-only.

Add php-7.2 test #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add php-7.2 test #4

wants to merge 1 commit into from

Conversation

peter279k
Copy link

Changed log

  • Add php-7.2 test in Travis CI build.
  • Change into >=7.1 inside require block in composer.json.
  • Upgrade the PHPUnit version to be ^6.5.
  • Using the class-based PHPUnit namespace to be compatible with the latest PHPUnit version.

Ocramius
Ocramius suggested changes Oct 25, 2018
View reviewed changes
composer.json Outdated
},
"require-dev": {
"phpunit/phpunit": "^5.7"
"phpunit/phpunit": "^6.5"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move to ^7?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It sounds good. I will set the PHPUnit for defining ^7.

@peter279k
Copy link
Author

peter279k commented Oct 26, 2018 •
edited
Loading

Hi @Ocramius, I've changed ^6.5 to ^7 for PHPUnit version.
If having any problems, please write the comments to let me know :).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Ocramius Ocramius Ocramius requested changes

Assignees

@peter279k peter279k

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peter279k @Ocramius