-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't hug parens if it would mean putting two # type: ignore
comments on the same line
#4037
base: main
Are you sure you want to change the base?
Conversation
Hmm, this might have been too hasty. The problem isn't |
# type: ignore
comment on the opening line# type: ignore
comments on the same line
The |
There's a scary-looking merge conflict, I think because I just merged #4012. Could you take a look? |
Seems to not be only the merge conflict, the new code also breaks tests from this branch. I'll have to take a closer look at some point. |
@henriholopainen have you had a chance to take another look? |
Description
Small refactor + fixes #4036
Checklist - did you ...
CHANGES.md
if necessary?