Divide by 32 on HashByteSlice #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On HashByteSlice we multiply by 32 instead of dividing the length of the slices. Use also unsafe as reflect is deprecated
terencechain
approved these changes
Jan 29, 2024
prestonvanloon
requested changes
Jan 29, 2024
prestonvanloon
approved these changes
Jan 29, 2024
Thompson1985
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On HashByteSlice we multiply by 32 instead of dividing the length of the slices.
Use also unsafe as reflect is deprecated
Also check for CPU support in
HashChunksthat is exported.fixes prysmaticlabs/prysm#13485