Segment name by script #568
wipflisonar.yml
on: pull_request
Analyze with Sonar
6m 15s
Annotations
10 warnings
|
Analyze with Sonar
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3, actions/setup-java@v3, actions/cache@v3, actions/github-script@v6. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
CRITICAL CODE_SMELL:
src/main/java/com/protomaps/basemap/names/OsmNames.java#L16
Refactor this method to reduce its Cognitive Complexity from 32 to the 15 allowed.
rule: java:S3776 (https://sonarcloud.io/organizations/protomaps/rules?open=java%3AS3776&rule_key=java%3AS3776)
issue url: https://sonarcloud.io/project/issues?pullRequest=273&open=AZDpFhPt7gE_muLeLQPD&id=protomaps_basemaps
|
|
MINOR CODE_SMELL:
src/main/java/com/protomaps/basemap/names/OsmNames.java#L26
Use isEmpty() to check whether the collection is empty or not.
rule: java:S1155 (https://sonarcloud.io/organizations/protomaps/rules?open=java%3AS1155&rule_key=java%3AS1155)
issue url: https://sonarcloud.io/project/issues?pullRequest=273&open=AZDpFhPt7gE_muLeLQPE&id=protomaps_basemaps
|
|
CRITICAL CODE_SMELL:
src/main/java/com/protomaps/basemap/names/OsmNames.java#L32
Define a constant instead of duplicating this literal "Latin" 3 times.
rule: java:S1192 (https://sonarcloud.io/organizations/protomaps/rules?open=java%3AS1192&rule_key=java%3AS1192)
issue url: https://sonarcloud.io/project/issues?pullRequest=273&open=AZDpFhPt7gE_muLeLQPB&id=protomaps_basemaps
|
|
CRITICAL CODE_SMELL:
src/main/java/com/protomaps/basemap/names/OsmNames.java#L32
Define a constant instead of duplicating this literal "Generic" 3 times.
rule: java:S1192 (https://sonarcloud.io/organizations/protomaps/rules?open=java%3AS1192&rule_key=java%3AS1192)
issue url: https://sonarcloud.io/project/issues?pullRequest=273&open=AZDpFhPt7gE_muLeLQPC&id=protomaps_basemaps
|
|
CRITICAL CODE_SMELL:
src/main/java/com/protomaps/basemap/names/ScriptSegmenter.java#L61
Refactor this method to reduce its Cognitive Complexity from 18 to the 15 allowed.
rule: java:S3776 (https://sonarcloud.io/organizations/protomaps/rules?open=java%3AS3776&rule_key=java%3AS3776)
issue url: https://sonarcloud.io/project/issues?pullRequest=273&open=AZDpFhPl7gE_muLeLQO8&id=protomaps_basemaps
|
|
MINOR CODE_SMELL:
src/main/java/com/protomaps/basemap/names/ScriptSegmenter.java#L106
Replace this if-then-else statement by a single return statement.
rule: java:S1126 (https://sonarcloud.io/organizations/protomaps/rules?open=java%3AS1126&rule_key=java%3AS1126)
issue url: https://sonarcloud.io/project/issues?pullRequest=273&open=AZDpFhPl7gE_muLeLQO9&id=protomaps_basemaps
|
|
CRITICAL CODE_SMELL:
src/main/java/com/protomaps/basemap/names/ScriptSegmenter.java#L113
Refactor this method to reduce its Cognitive Complexity from 26 to the 15 allowed.
rule: java:S3776 (https://sonarcloud.io/organizations/protomaps/rules?open=java%3AS3776&rule_key=java%3AS3776)
issue url: https://sonarcloud.io/project/issues?pullRequest=273&open=AZDpFhPl7gE_muLeLQO-&id=protomaps_basemaps
|
|
MAJOR CODE_SMELL:
src/main/java/com/protomaps/basemap/names/ScriptSegmenter.java#L178
Replace this use of System.out by a logger.
rule: java:S106 (https://sonarcloud.io/organizations/protomaps/rules?open=java%3AS106&rule_key=java%3AS106)
issue url: https://sonarcloud.io/project/issues?pullRequest=273&open=AZDpFhPl7gE_muLeLQO_&id=protomaps_basemaps
|
|
MAJOR CODE_SMELL:
src/main/java/com/protomaps/basemap/names/ScriptSegmenter.java#L180
Replace this use of System.out by a logger.
rule: java:S106 (https://sonarcloud.io/organizations/protomaps/rules?open=java%3AS106&rule_key=java%3AS106)
issue url: https://sonarcloud.io/project/issues?pullRequest=273&open=AZDpFhPl7gE_muLeLQPA&id=protomaps_basemaps
|