Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Builder Api #28

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Builder Api #28

wants to merge 2 commits into from

Conversation

dbcfd
Copy link
Collaborator

@dbcfd dbcfd commented Dec 10, 2020

Provide a builder style api for creating pending handles, then activating them.
Config now supports specifying interface to simplify creation, and a stream can
be created from a config without needing to first create a handle.

This was referenced Dec 10, 2020
Copy link

@rossmacarthur rossmacarthur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I made, some small comments, I will test out this branch as well :)

src/handle.rs Outdated Show resolved Hide resolved
src/handle.rs Outdated Show resolved Hide resolved
Introduce a builder api that better supports creating pending and activated
handles, and creating streams from those handles. Config now supports defining
which handle type (dead, live, file).

Additional support for configuring handles with linktype and rfmon.
@dbcfd
Copy link
Collaborator Author

dbcfd commented Dec 11, 2020

Thanks, I made, some small comments, I will test out this branch as well :)

Made changes per review, and added rfmon support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants