-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(blockdevice): added sysblockdevicesize method and test #650
Conversation
need to add edit: i believe i did this in 8dc60f1 |
blockdevice/stats.go
Outdated
if err != nil { | ||
return 0, err | ||
} | ||
return 512 * size, nil |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's make this a const SectorSize
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just following up on this cc @discordianfish |
or cc @SuperQ |
hey could I get a review on this please? any idea who might be best to take a look @dswarbrick |
@fs185143 You'll have better luck attracting the attention of maintainers if all CI tests are green, plus all commits need to be signed off to comply with the DCO. |
c5589cf
to
b0b6389
Compare
closing in favour of #658 (fixed issues like DCO) |
In part to support prometheus/node_exporter#3068, I have added a new method that retrieves the value of
/sys/block/<device>/size