Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cpuinfo: Enable for all 32-bit ARM CPUs #292

Merged
merged 1 commit into from
May 13, 2020

Conversation

bluecmd
Copy link
Contributor

@bluecmd bluecmd commented May 12, 2020

Repurpose the ARMv6 cpuinfo for all ARM CPUs. CPU info format likely is
not dependent on instruction set version.

Signed-off-by: Christian Svensson [email protected]

Fixes #291

Repurpose the ARMv6 cpuinfo for all ARM CPUs. CPU info format likely is
not dependent on instruction set version.

Signed-off-by: Christian Svensson <[email protected]>
@bluecmd
Copy link
Contributor Author

bluecmd commented May 13, 2020

This fixes the compilation for ARM 32-bit, but the current parsing code only works for kernels older than v3.8.

I think there is value to merging this while the format question is resolved - if nothing else to allow 32-bit ARM to build.

WDYT @discordianfish ?

Copy link
Member

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SuperQ
Copy link
Member

SuperQ commented May 13, 2020

One thing we could do here is to build a set of tests that run on different architectures/kernels. This could be done by adding to the buildkite setup we have for the node_exporter.

With buildkite, we run a few different build agents under KVM/QEMU, so we're not dependent on the limited platforms available on CircleCI.

@bluecmd bluecmd marked this pull request as ready for review May 13, 2020 14:31
@discordianfish discordianfish merged commit c6ff04b into prometheus:master May 13, 2020
@discordianfish
Copy link
Member

Fixing the parsing itself can be done in another PR, so LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No CPUInfo for all ARM
3 participants