Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Add chip label to the
node_drm_card_info
metric.Solution
Extend the DRM collector to have the
chip
label from theClassDRMCardAMDGPUStats
.The change was also proposed in the procfs repo, and the PR is awaiting review.
Context
The DRM metrics are impossible to relate to the
hwmon
metrics, which export other helpful information about AMD GPUs. The extension will allow us to relate metrics from both 'hwmonand 'drm
and, in turn, create a better GPU Dashboard for AMD with proper filtering and labelling.Demo example metrics:
and: