Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend DRM labels #3145

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Extend DRM labels #3145

wants to merge 1 commit into from

Conversation

Deezzir
Copy link

@Deezzir Deezzir commented Oct 3, 2024

Issue

Add chip label to the node_drm_card_info metric.

Solution

Extend the DRM collector to have the chip label from the ClassDRMCardAMDGPUStats.
The change was also proposed in the procfs repo, and the PR is awaiting review.

Context

The DRM metrics are impossible to relate to the hwmon metrics, which export other helpful information about AMD GPUs. The extension will allow us to relate metrics from both 'hwmon and 'drm and, in turn, create a better GPU Dashboard for AMD with proper filtering and labelling.

Demo example metrics:

node_drm_card_info{card="card0",chip="0000:9d:00_0_0000:9e:00_0",memory_vendor="samsung",power_performance_level="auto",unique_id="",vendor="amd"} 1
node_drm_gpu_busy_percent{card="card0"} 0
node_drm_memory_gtt_size_bytes{card="card0"} 4.294967296e+09
node_drm_memory_gtt_used_bytes{card="card0"} 8.081408e+06
node_drm_memory_vis_vram_size_bytes{card="card0"} 2.68435456e+08
node_drm_memory_vis_vram_used_bytes{card="card0"} 5.439488e+06
node_drm_memory_vram_size_bytes{card="card0"} 4.294967296e+09
node_drm_memory_vram_used_bytes{card="card0"} 5.57056e+06
node_scrape_collector_duration_seconds{collector="drm"} 0.000537504
node_scrape_collector_success{collector="drm"} 1

and:

...
node_hwmon_chip_names{chip="0000:9d:00_0_0000:9e:00_0",chip_name="amdgpu"} 1
...

Signed-off-by: Deezzir <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant