Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zfs: Only attempt to pull mibs from supported Releases #3141

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dekimsey
Copy link
Contributor

@dekimsey dekimsey commented Oct 2, 2024

In particular 14.0 changed the way arcstats were listed, but we previously attempted to grab them all. By adding a bit of a major release detection we reduce the error noise.

The collector was still functioning, but FreeBSD users were seeing a large spam of error logs like such:

msg="collector failed" name=zfs err="couldn't get sysctl: no such file or directory"

Instead, the zfs collector will now select the appropriate arcstat metrics for the release. A warning is generated once during start-up if it was unable to determine the OS release.

Resolves #2847

TODOs

  • test & verify the PR on freebsd

In particular 14.0 changed the way arcstats were listed, but we
previously attempted to grab them all. By adding a bit of a major
release detection we reduce the error noise.

Signed-off-by: Daniel Kimsey <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

node_exporter collector failure for zfs err="couldn't get sysctl: no such file or directory"
1 participant