Add exclude[] parameter
#3116
Merged
Add exclude[] parameter
#3116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like it, thanks! Minor nit, I think to follow our naming pattern, we should call this |
siavashs
force-pushed
the
discard-parameter
branch
from
7fc81ff
to
5cdebd2
Compare
|
Thanks for the suggestion and fixing the logging @SuperQ |
SuperQ
reviewed
Sep 13, 2024
siavashs
force-pushed
the
discard-parameter
branch
from
5cdebd2
to
82aa649
Compare
SuperQ
requested changes
Sep 13, 2024
siavashs
force-pushed
the
discard-parameter
branch
from
82aa649
to
0df318c
Compare
This PR adds a `exclude[]` URL parameter to exclude specific enabled collectors. Compared to `collect[]` parameter, the `exclude[]` parameter results in a filtered list which equals enabled collectors minus excluded ones. Signed-off-by: Siavash Safi <[email protected]>
siavashs
force-pushed
the
discard-parameter
branch
from
0df318c
to
12dedef
Compare
rongyi
pushed a commit
to ontology-tech/node_exporter
that referenced
this pull request
Oct 17, 2024
This PR adds a `exclude[]` URL parameter to exclude specific enabled collectors. Compared to `collect[]` parameter, the `exclude[]` parameter results in a filtered list which equals enabled collectors minus excluded ones. Signed-off-by: Siavash Safi <[email protected]>
v-zhuravlev
pushed a commit
to grafana/node_exporter
that referenced
this pull request
Nov 1, 2024
This PR adds a `exclude[]` URL parameter to exclude specific enabled collectors. Compared to `collect[]` parameter, the `exclude[]` parameter results in a filtered list which equals enabled collectors minus excluded ones. Signed-off-by: Siavash Safi <[email protected]> Signed-off-by: Vitaly Zhuravlev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an
exclude[]URL parameter to exclude specific enabled collectors.Compared to
collect[]parameter, theexclude[]parameter results in a filtered list which equals enabled collectors minus excluded ones.