Update golangci-lint config

* Migrate from Python codespell to golangci-lint misspell. * Inline errcheck exclude list in the golangci-lint config. Signed-off-by: Ben Kochie <[email protected]>
prometheus · Jun 17, 2023 · ba2e88e · ba2e88e
1 parent 742ec09
commit ba2e88e
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 22 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -28,13 +28,6 @@ jobs:
       - checkout
       - run: uname -a
       - run: make test-e2e
-  codespell:
-    docker:
-      - image: circleci/python
-    steps:
-      - checkout
-      - run: sudo pip install codespell
-      - run: codespell --skip=".git,./vendor,ttar,go.mod,go.sum,*pem,./collector/fixtures" -I scripts/codespell_ignore.txt
   test_mixins:
     executor: golang
     steps:
@@ -105,10 +98,6 @@ workflows:
           filters:
             tags:
               only: /.*/
-      - codespell:
-          filters:
-            tags:
-              only: /.*/
       - test_docker:
           requires:
             - test

diff --git a/.golangci.yml b/.golangci.yml
@@ -1,5 +1,6 @@
 linters:
   enable:
+    - misspell
     - revive
   disable:
     # Disable soon to deprecated[1] linters that lead to false
@@ -19,4 +20,8 @@ issues:
 
 linters-settings:
   errcheck:
-    exclude: scripts/errcheck_excludes.txt
+    exclude-functions:
+      # Used in HTTP handlers, any error is handled by the server itself.
+      - (net/http.ResponseWriter).Write
+      # Never check for logger errors.
+      - (github.com/go-kit/log.Logger).Log
diff --git a/scripts/codespell_ignore.txt b/scripts/codespell_ignore.txt
diff --git a/scripts/errcheck_excludes.txt b/scripts/errcheck_excludes.txt