Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slog: expose io.Writer #694

Merged
merged 1 commit into from
Sep 14, 2024
Merged

slog: expose io.Writer #694

merged 1 commit into from
Sep 14, 2024

Conversation

jkroepke
Copy link
Contributor

@jkroepke jkroepke commented Sep 7, 2024

While implementing the new slog logger at windows_exporter, I figure out that I'm unable to set the Writer as I could on slog.

Define the Writer is important for windows. stdout and stderr are not captured, if programs running as Windows Service.

On windows_exporter, I implement a io.Writer which is able to write data to the Windows Event Log and I would like to use that writer.

Signed-off-by: Jan-Otto Kröpke <[email protected]>
@ArthurSens ArthurSens merged commit 40d6251 into prometheus:main Sep 14, 2024
7 checks passed
@jkroepke jkroepke deleted the slog/writer branch September 14, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants