enable utf-8 validation mode by default #680
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ywwg
force-pushed
the
owilliams/utf8-default
branch
from
12dcdf6
to
fbdace4
Compare
Signed-off-by: Owen Williams <[email protected]>
ywwg
force-pushed
the
owilliams/utf8-default
branch
from
fbdace4
to
517feb8
Compare
|
Isn't the idea that Prometheus v3 can use UTF-8 by default without this change in common? We can still have this change here, but we have to communicate to users of this package that they now have to actively opt out of UTF-8 support. I don't think the change here has to be locked to the v3 release in any way. |
|
ahh that makes sense. Closing for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of prometheus/prometheus#13095
This should be part of Prometheus 3.0, do we need a separate feature branch for the common library so we can schedule when the change is committed?