Revert #576 and add deprecation notice #665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuperQ
force-pushed
the
superq/revert_unexport
branch
2 times, most recently
from
7086aac
to
3fc249a
Compare
This reverts commit 05d7387. Signed-off-by: SuperQ <[email protected]>
Add deprecation notice to format strings to allow transition to new functionality. Signed-off-by: SuperQ <[email protected]>
SuperQ
force-pushed
the
superq/revert_unexport
branch
from
3fc249a
to
c3e8247
Compare
kylelemons
approved these changes
Jul 15, 2024
|
Confirmed that |
|
Do we need to re-export all the constants, or would re-exporting FmtText only as in #666 be sufficient? |
|
I recommend a full revert so any downstream use can get the deprecation notice. |
beorn7
approved these changes
Jul 15, 2024
|
If we go down the deprecation path in a 0.x library at all, then let's be as conservative and do it for all the constants. |
We might want to discuss common 1.0 in a dev summit |
ArthurSens
approved these changes
Jul 15, 2024
|
Hi, do you know when the next release tag with this PR is coming out? |
Second this? Any progress? I was broken with |
|
We should have a new release today or tomorrow. We're finishing up a couple other changes. |
XSAM
pushed a commit
to XSAM/otelsql
that referenced
this pull request
Aug 27, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/prometheus/common](https://togithub.com/prometheus/common) | `v0.55.0` -> `v0.56.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>prometheus/common (github.com/prometheus/common)</summary> ### [`v0.56.0`](https://togithub.com/prometheus/common/releases/tag/v0.56.0) #### What's Changed - Don't always fetch a OAuth2 token, if the secret from a file didn't change by [@​multani](https://togithub.com/multani) in [prometheus/common#647 - remove dependency to github.com/prometheus/client_golang by [@​ilius](https://togithub.com/ilius) in [prometheus/common#662 - Bump github.com/aws/aws-sdk-go from 1.54.7 to 1.54.11 in /sigv4 by [@​dependabot](https://togithub.com/dependabot) in [prometheus/common#661 - Synchronize common files from prometheus/prometheus by [@​prombot](https://togithub.com/prombot) in [prometheus/common#664 - Revert [#​576](https://togithub.com/prometheus/common/issues/576) and add deprecation notice by [@​SuperQ](https://togithub.com/SuperQ) in [prometheus/common#665 - Bump golang.org/x/net from 0.26.0 to 0.27.0 by [@​dependabot](https://togithub.com/dependabot) in [prometheus/common#667 - use basic string in IsValidLegacyMetricName by [@​ywwg](https://togithub.com/ywwg) in [prometheus/common#668 - Synchronize common files from prometheus/prometheus by [@​prombot](https://togithub.com/prombot) in [prometheus/common#672 - Synchronize common files from prometheus/prometheus by [@​prombot](https://togithub.com/prombot) in [prometheus/common#674 - Bump github.com/aws/aws-sdk-go from 1.54.19 to 1.55.5 in /sigv4 by [@​dependabot](https://togithub.com/dependabot) in [prometheus/common#671 - sigv4: support nil body by [@​roidelapluie](https://togithub.com/roidelapluie) in [prometheus/common#673 - Fix overflows of untyped int constants on 32-bit by [@​dswarbrick](https://togithub.com/dswarbrick) in [prometheus/common#675 - Update client_golang by [@​SuperQ](https://togithub.com/SuperQ) in [prometheus/common#676 - Update golangci lint by [@​roidelapluie](https://togithub.com/roidelapluie) in [prometheus/common#679 - expfmt: Add UTF-8 syntax support in text_parse.go by [@​fedetorres93](https://togithub.com/fedetorres93) in [prometheus/common#670 - Synchronize common files from prometheus/prometheus by [@​prombot](https://togithub.com/prombot) in [prometheus/common#681 - fix(utf8): provide a method for explicitly checking label names for legacy validity by [@​ywwg](https://togithub.com/ywwg) in [prometheus/common#682 #### New Contributors - [@​multani](https://togithub.com/multani) made their first contribution in [prometheus/common#647 - [@​ilius](https://togithub.com/ilius) made their first contribution in [prometheus/common#662 - [@​dswarbrick](https://togithub.com/dswarbrick) made their first contribution in [prometheus/common#675 - [@​fedetorres93](https://togithub.com/fedetorres93) made their first contribution in [prometheus/common#670 **Full Changelog**: prometheus/common@v0.55.0...v0.56.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/XSAM/otelsql). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yNi4xIiwidXBkYXRlZEluVmVyIjoiMzguMjYuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
codeboten
pushed a commit
to open-telemetry/opentelemetry-collector
that referenced
this pull request
Aug 28, 2024
](https://renovatebot.com){kind=link}
) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/prometheus/common](https://togithub.com/prometheus/common) | `v0.55.0` -> `v0.56.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>prometheus/common (github.com/prometheus/common)</summary> ### [`v0.56.0`](https://togithub.com/prometheus/common/releases/tag/v0.56.0) [Compare Source](https://togithub.com/prometheus/common/compare/v0.55.0...v0.56.0) #### What's Changed - Don't always fetch a OAuth2 token, if the secret from a file didn't change by [@​multani](https://togithub.com/multani) in [prometheus/common#647 - remove dependency to github.com/prometheus/client_golang by [@​ilius](https://togithub.com/ilius) in [prometheus/common#662 - Bump github.com/aws/aws-sdk-go from 1.54.7 to 1.54.11 in /sigv4 by [@​dependabot](https://togithub.com/dependabot) in [prometheus/common#661 - Synchronize common files from prometheus/prometheus by [@​prombot](https://togithub.com/prombot) in [prometheus/common#664 - Revert [#​576](https://togithub.com/prometheus/common/issues/576) and add deprecation notice by [@​SuperQ](https://togithub.com/SuperQ) in [prometheus/common#665 - Bump golang.org/x/net from 0.26.0 to 0.27.0 by [@​dependabot](https://togithub.com/dependabot) in [prometheus/common#667 - use basic string in IsValidLegacyMetricName by [@​ywwg](https://togithub.com/ywwg) in [prometheus/common#668 - Synchronize common files from prometheus/prometheus by [@​prombot](https://togithub.com/prombot) in [prometheus/common#672 - Synchronize common files from prometheus/prometheus by [@​prombot](https://togithub.com/prombot) in [prometheus/common#674 - Bump github.com/aws/aws-sdk-go from 1.54.19 to 1.55.5 in /sigv4 by [@​dependabot](https://togithub.com/dependabot) in [prometheus/common#671 - sigv4: support nil body by [@​roidelapluie](https://togithub.com/roidelapluie) in [prometheus/common#673 - Fix overflows of untyped int constants on 32-bit by [@​dswarbrick](https://togithub.com/dswarbrick) in [prometheus/common#675 - Update client_golang by [@​SuperQ](https://togithub.com/SuperQ) in [prometheus/common#676 - Update golangci lint by [@​roidelapluie](https://togithub.com/roidelapluie) in [prometheus/common#679 - expfmt: Add UTF-8 syntax support in text_parse.go by [@​fedetorres93](https://togithub.com/fedetorres93) in [prometheus/common#670 - Synchronize common files from prometheus/prometheus by [@​prombot](https://togithub.com/prombot) in [prometheus/common#681 - fix(utf8): provide a method for explicitly checking label names for legacy validity by [@​ywwg](https://togithub.com/ywwg) in [prometheus/common#682 #### New Contributors - [@​multani](https://togithub.com/multani) made their first contribution in [prometheus/common#647 - [@​ilius](https://togithub.com/ilius) made their first contribution in [prometheus/common#662 - [@​dswarbrick](https://togithub.com/dswarbrick) made their first contribution in [prometheus/common#675 - [@​fedetorres93](https://togithub.com/fedetorres93) made their first contribution in [prometheus/common#670 **Full Changelog**: prometheus/common@v0.55.0...v0.56.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/open-telemetry/opentelemetry-collector). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yNi4xIiwidXBkYXRlZEluVmVyIjoiMzguNTYuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiZGVwZW5kZW5jaWVzIiwicmVub3ZhdGVib3QiXX0=--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <[email protected]>
MrAlias
pushed a commit
to open-telemetry/opentelemetry-go-contrib
that referenced
this pull request
Aug 29, 2024
…6059) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/prometheus/common](https://togithub.com/prometheus/common) | `v0.55.0` -> `v0.57.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>prometheus/common (github.com/prometheus/common)</summary> ### [`v0.57.0`](https://togithub.com/prometheus/common/releases/tag/v0.57.0) [Compare Source](https://togithub.com/prometheus/common/compare/v0.56.0...v0.57.0) #### What's Changed - feat: new promslog and promslog/flag packages to wrap log/slog by [@​tjhop](https://togithub.com/tjhop) in [prometheus/common#677 #### New Contributors - [@​tjhop](https://togithub.com/tjhop) made their first contribution in [prometheus/common#677 **Full Changelog**: prometheus/common@v0.56.0...v0.57.0 ### [`v0.56.0`](https://togithub.com/prometheus/common/releases/tag/v0.56.0) [Compare Source](https://togithub.com/prometheus/common/compare/v0.55.0...v0.56.0) #### What's Changed - Don't always fetch a OAuth2 token, if the secret from a file didn't change by [@​multani](https://togithub.com/multani) in [prometheus/common#647 - remove dependency to github.com/prometheus/client_golang by [@​ilius](https://togithub.com/ilius) in [prometheus/common#662 - Bump github.com/aws/aws-sdk-go from 1.54.7 to 1.54.11 in /sigv4 by [@​dependabot](https://togithub.com/dependabot) in [prometheus/common#661 - Synchronize common files from prometheus/prometheus by [@​prombot](https://togithub.com/prombot) in [prometheus/common#664 - Revert [#​576](https://togithub.com/prometheus/common/issues/576) and add deprecation notice by [@​SuperQ](https://togithub.com/SuperQ) in [prometheus/common#665 - Bump golang.org/x/net from 0.26.0 to 0.27.0 by [@​dependabot](https://togithub.com/dependabot) in [prometheus/common#667 - use basic string in IsValidLegacyMetricName by [@​ywwg](https://togithub.com/ywwg) in [prometheus/common#668 - Synchronize common files from prometheus/prometheus by [@​prombot](https://togithub.com/prombot) in [prometheus/common#672 - Synchronize common files from prometheus/prometheus by [@​prombot](https://togithub.com/prombot) in [prometheus/common#674 - Bump github.com/aws/aws-sdk-go from 1.54.19 to 1.55.5 in /sigv4 by [@​dependabot](https://togithub.com/dependabot) in [prometheus/common#671 - sigv4: support nil body by [@​roidelapluie](https://togithub.com/roidelapluie) in [prometheus/common#673 - Fix overflows of untyped int constants on 32-bit by [@​dswarbrick](https://togithub.com/dswarbrick) in [prometheus/common#675 - Update client_golang by [@​SuperQ](https://togithub.com/SuperQ) in [prometheus/common#676 - Update golangci lint by [@​roidelapluie](https://togithub.com/roidelapluie) in [prometheus/common#679 - expfmt: Add UTF-8 syntax support in text_parse.go by [@​fedetorres93](https://togithub.com/fedetorres93) in [prometheus/common#670 - Synchronize common files from prometheus/prometheus by [@​prombot](https://togithub.com/prombot) in [prometheus/common#681 - fix(utf8): provide a method for explicitly checking label names for legacy validity by [@​ywwg](https://togithub.com/ywwg) in [prometheus/common#682 #### New Contributors - [@​multani](https://togithub.com/multani) made their first contribution in [prometheus/common#647 - [@​ilius](https://togithub.com/ilius) made their first contribution in [prometheus/common#662 - [@​dswarbrick](https://togithub.com/dswarbrick) made their first contribution in [prometheus/common#675 - [@​fedetorres93](https://togithub.com/fedetorres93) made their first contribution in [prometheus/common#670 **Full Changelog**: prometheus/common@v0.55.0...v0.56.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/open-telemetry/opentelemetry-go-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yNi4xIiwidXBkYXRlZEluVmVyIjoiMzguNTYuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiU2tpcCBDaGFuZ2Vsb2ciLCJkZXBlbmRlbmNpZXMiXX0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
MrAlias
pushed a commit
to open-telemetry/opentelemetry-go
that referenced
this pull request
Aug 29, 2024
…5748) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/prometheus/common](https://togithub.com/prometheus/common) | `v0.55.0` -> `v0.57.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>prometheus/common (github.com/prometheus/common)</summary> ### [`v0.57.0`](https://togithub.com/prometheus/common/releases/tag/v0.57.0) [Compare Source](https://togithub.com/prometheus/common/compare/v0.56.0...v0.57.0) #### What's Changed - feat: new promslog and promslog/flag packages to wrap log/slog by [@​tjhop](https://togithub.com/tjhop) in [prometheus/common#677 #### New Contributors - [@​tjhop](https://togithub.com/tjhop) made their first contribution in [prometheus/common#677 **Full Changelog**: prometheus/common@v0.56.0...v0.57.0 ### [`v0.56.0`](https://togithub.com/prometheus/common/releases/tag/v0.56.0) [Compare Source](https://togithub.com/prometheus/common/compare/v0.55.0...v0.56.0) #### What's Changed - Don't always fetch a OAuth2 token, if the secret from a file didn't change by [@​multani](https://togithub.com/multani) in [prometheus/common#647 - remove dependency to github.com/prometheus/client_golang by [@​ilius](https://togithub.com/ilius) in [prometheus/common#662 - Bump github.com/aws/aws-sdk-go from 1.54.7 to 1.54.11 in /sigv4 by [@​dependabot](https://togithub.com/dependabot) in [prometheus/common#661 - Synchronize common files from prometheus/prometheus by [@​prombot](https://togithub.com/prombot) in [prometheus/common#664 - Revert [#​576](https://togithub.com/prometheus/common/issues/576) and add deprecation notice by [@​SuperQ](https://togithub.com/SuperQ) in [prometheus/common#665 - Bump golang.org/x/net from 0.26.0 to 0.27.0 by [@​dependabot](https://togithub.com/dependabot) in [prometheus/common#667 - use basic string in IsValidLegacyMetricName by [@​ywwg](https://togithub.com/ywwg) in [prometheus/common#668 - Synchronize common files from prometheus/prometheus by [@​prombot](https://togithub.com/prombot) in [prometheus/common#672 - Synchronize common files from prometheus/prometheus by [@​prombot](https://togithub.com/prombot) in [prometheus/common#674 - Bump github.com/aws/aws-sdk-go from 1.54.19 to 1.55.5 in /sigv4 by [@​dependabot](https://togithub.com/dependabot) in [prometheus/common#671 - sigv4: support nil body by [@​roidelapluie](https://togithub.com/roidelapluie) in [prometheus/common#673 - Fix overflows of untyped int constants on 32-bit by [@​dswarbrick](https://togithub.com/dswarbrick) in [prometheus/common#675 - Update client_golang by [@​SuperQ](https://togithub.com/SuperQ) in [prometheus/common#676 - Update golangci lint by [@​roidelapluie](https://togithub.com/roidelapluie) in [prometheus/common#679 - expfmt: Add UTF-8 syntax support in text_parse.go by [@​fedetorres93](https://togithub.com/fedetorres93) in [prometheus/common#670 - Synchronize common files from prometheus/prometheus by [@​prombot](https://togithub.com/prombot) in [prometheus/common#681 - fix(utf8): provide a method for explicitly checking label names for legacy validity by [@​ywwg](https://togithub.com/ywwg) in [prometheus/common#682 #### New Contributors - [@​multani](https://togithub.com/multani) made their first contribution in [prometheus/common#647 - [@​ilius](https://togithub.com/ilius) made their first contribution in [prometheus/common#662 - [@​dswarbrick](https://togithub.com/dswarbrick) made their first contribution in [prometheus/common#675 - [@​fedetorres93](https://togithub.com/fedetorres93) made their first contribution in [prometheus/common#670 **Full Changelog**: prometheus/common@v0.55.0...v0.56.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/open-telemetry/opentelemetry-go). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yNi4xIiwidXBkYXRlZEluVmVyIjoiMzguNTYuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiU2tpcCBDaGFuZ2Vsb2ciLCJkZXBlbmRlbmNpZXMiXX0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert #576 that un-exported format strings and replace with a deprecation notice.