Expose HTTPHost property in HTTPClientConfig #645
Conversation
jkroepke
force-pushed
the
host
branch
4 times, most recently
from
c414f4d
to
e849aa2
Compare
Signed-off-by: Jan-Otto Kröpke <[email protected]>
| @@ -319,6 +319,9 @@ type HTTPClientConfig struct { | |||
| // The omitempty flag is not set, because it would be hidden from the | |||
| // marshalled configuration when set to false. | |||
| EnableHTTP2 bool `yaml:"enable_http2" json:"enable_http2"` | |||
| // HTTPHost optionally overrides the Host header to send. | |||
| // If empty, the host from the URL is used. | |||
There was a problem hiding this comment.
How does this reconcile with the code that says:
rt = NewHostRoundTripper(opts.host, rt)
There was a problem hiding this comment.
If empty, the host from the URL is used.
This is go default behavior. It's similar the the TLSServerName property.
If the property is not set by caller, then the value will be used from URL.
There was a problem hiding this comment.
Would it not be more correct to mention opts.host ?
|
In #549 you added Since only the latter was used, I removed the former. Now you adding it back, and hopefully using it. |
|
Hey @bboreham, I only need the property in HTTPClientConfig within the context of Grafana Alloy. I have to apologize. When I started with Golang a year ago, I implemented the wrong side due to my lack of knowledge and missing tooling. I just replicated the userAgent logic, which misled me. Looking at it now, I realize that the host property in httpClientOptions is incorrect. If you agree, I can revert the host in httpClientOptions. |
|
Thanks for the explanation. It's fine, everybody makes mistakes. Just easier for me to follow if I can see the path. However we may prefer to deprecate the un-needed one rather than removing it immediately. |
While I was integrate that feature in grafana/alloy#698, it figure out that the Host property was removed in #597. Turns out that I forget something.
Since host is problematic with DockerSD, i choice the term
http_hostto follow the pattern fromhttp_headers