Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add color logging capabilities for promlog #457

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Conversation

SuperQ
Copy link
Member

@SuperQ SuperQ commented Feb 25, 2023

Cherry-pick color logging functionality from #113.

Cherry-pick color logging functionality from #113.

Signed-off-by: SuperQ <[email protected]>
@roidelapluie
Copy link
Member

Can we make this opt in with a flag --log.color ?

@SuperQ
Copy link
Member Author

SuperQ commented Feb 25, 2023

@roidelapluie Sure, done. I made it opt-out. 😁

@roidelapluie
Copy link
Member

I am pretty sure making it opt out will be an annoyance. It's also personal taste of course.

@roidelapluie
Copy link
Member

We are using a trick to look at the stack to print the file and line number. It might be worth it to double check that this does not get in the way.

@roidelapluie
Copy link
Member

I have tested the PR and it does not work.

@SuperQ
Copy link
Member Author

SuperQ commented Feb 25, 2023

Boo, ok. I'll poke around to see if I can make it work. I was just trying to rebase on the old PR.

@SuperQ SuperQ marked this pull request as draft February 25, 2023 17:27
@roidelapluie
Copy link
Member

roidelapluie commented Feb 25, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants