Nullify noLabels in StatefulMetric during clear() to prevent no-label…

…s increase to stop working (#972) Signed-off-by: Iacopo Pace <[email protected]> Co-authored-by: Iacopo Pace <[email protected]>
prometheus · Sep 7, 2024 · b2db709 · b2db709
1 parent ec56b2c
commit b2db709
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/prometheus-metrics-core/src/main/java/io/prometheus/metrics/core/metrics/StatefulMetric.java b/prometheus-metrics-core/src/main/java/io/prometheus/metrics/core/metrics/StatefulMetric.java
@@ -114,6 +114,7 @@ public void remove(String... labelValues) {
      */
     public void clear() {
         data.clear();
+        noLabels = null;
     }
 
     protected abstract T newDataPoint();

diff --git a/...eus-metrics-core/src/test/java/io/prometheus/metrics/core/metrics/StatefulMetricTest.java b/...eus-metrics-core/src/test/java/io/prometheus/metrics/core/metrics/StatefulMetricTest.java
@@ -60,5 +60,10 @@ public void testClearNoLabels() {
         // No labels is always present, but as no value has been observed after clear() the value should be 0.0
         Assert.assertEquals(1, counter.collect().getDataPoints().size());
         Assert.assertEquals(0.0, counter.collect().getDataPoints().get(0).getValue(), 0.0);
+
+        // Making inc() works correctly after clear()
+        counter.inc();
+        Assert.assertEquals(1, counter.collect().getDataPoints().size());
+        Assert.assertEquals(1.0, counter.collect().getDataPoints().get(0).getValue(), 0.0);
     }
 }