Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2522: Incorrect Pod Memory Usage (WSS) Graph Behaviour #2524

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vladmalynych
Copy link

@vladmalynych vladmalynych commented Sep 20, 2024

Fixes #2522

Description

This PR addresses an issue where, upon restarting a pod, the query aggregates memory usage data from both the old and new containers. This results in temporary spikes in the displayed memory consumption, potentially causing the dashboard to show memory usage that exceeds the pod's memory limit, even though actual usage remains within the limit.

Current behaviour:
Screenshot 2024-09-20 at 15 41 23

Updated behaviour:
Screenshot 2024-09-20 at 15 42 28

Type of change

What type of changes does your code introduce to the kube-prometheus? Put an x in the box that apply.

  • CHANGE (fix or feature that would cause existing functionality to not work as expected)
  • FEATURE (non-breaking change which adds functionality)
  • BUGFIX (non-breaking change which fixes an issue)
  • ENHANCEMENT (non-breaking change which improves existing functionality)
  • NONE (if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)

Changelog entry

Please put a one-line changelog entry below. Later this will be copied to the changelog file.

- Fix Grafana Pod dashboard showing incorrect Pod Memory Usage (WSS) due to memory data from restarted containers being combined.

@vladmalynych vladmalynych requested a review from a team as a code owner September 20, 2024 13:55
@github-actions github-actions bot added the stale label Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect Container Memory Consumption Graph Behavior When Pod is Restarted
1 participant