Add helium_level to the list of smartmon attributes to report. #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ben Livengood <[email protected]>
benlivengood
force-pushed
the
add_helium_level_to_smartmon_sh
branch
from
371d2db
to
199c66b
Compare
|
Thanks, but since the smartmon.sh script is essentially superseded by the smartmon.py, and will likely be removed at some point in future, can you please add this to smartmon.py also? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of my hard drives export
22 Helium_Levelas an attribute, and I want to monitor them.I've tested this change locally to make sure the new metrics appear in prometheus.