Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an exporter for FreeBSD rc services #129

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

0mp
Copy link
Contributor

@0mp 0mp commented Nov 17, 2022

This script exports FreeBSD rc service status information whether a given service is running or not.

Sponsored by: Klara Inc.
Sponsored by: ELW – Entsorgungsbetriebe der Landeshauptstadt Wiesbaden
Signed-off-by: Mateusz Piotrowski [email protected]

@0mp 0mp force-pushed the freebsd-rc-service-status branch 2 times, most recently from 0bae38b to 06335fa Compare November 17, 2022 15:27
@0mp
Copy link
Contributor Author

0mp commented Nov 17, 2022

OK, I've fixed some things that the CI was complaining about.

freebsd-rc-service.sh Outdated Show resolved Hide resolved
This script exports FreeBSD rc service status information whether a
given service is running or not.

Sponsored by:  Klara Inc.
Sponsored by:  ELW – Entsorgungsbetriebe der Landeshauptstadt Wiesbaden
Signed-off-by: Mateusz Piotrowski <[email protected]>
@0mp 0mp requested a review from dswarbrick November 19, 2022 13:50
@0mp
Copy link
Contributor Author

0mp commented Dec 13, 2022

Thanks @discordianfish!

@@ -0,0 +1,139 @@
#! /bin/sh -
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any chance this could be made /usr/bin/env sh to align with the shebangs used by other collectors?

Comment on lines +37 to +47
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The whole repo is already licensed as Apache-2.0. This is superfluous.

#

help() {

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superfluous blank line.

# (but not ideal) indication of which services are long-running programs like
# web servers.
list_services_with_status() {

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superfluous blank line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants