file: Support reading EFI zboot images #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hexchain
force-pushed
the
aarch64-zboot
branch
from
7a06c90
to
0a6bc2f
Compare
mgorny
reviewed
Sep 21, 2024
ecleankernel/file.py
Outdated
Comment on lines
237
to
239
| image = f.read(size) | ||
|
|
||
| return self.read_version_from_raw(io.BytesIO(image)) |
There was a problem hiding this comment.
Any reason you're prereading it, rather than calling self.read_version_from_raw on the seeked file?
There was a problem hiding this comment.
gzip.decompress throws when it tries to read past the end of the payload.
There was a problem hiding this comment.
Can we instead modify read_version_from_raw() and related functions to take an optional size?
|
Oh, and we're going to need a test for this file format. |
hexchain
force-pushed
the
aarch64-zboot
branch
from
0a6bc2f
to
367ca82
Compare
hexchain
force-pushed
the
aarch64-zboot
branch
from
367ca82
to
a3e6ca0
Compare
|
All done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This type of image is generated when the kernel has
CONFIG_EFI_ZBOOTenabled.