Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor extractor #987

Merged
merged 1 commit into from
Sep 21, 2023
Merged

refactor extractor #987

merged 1 commit into from
Sep 21, 2023

Conversation

dogancanbakir
Copy link
Member

@dogancanbakir dogancanbakir commented Sep 13, 2023 •
edited by RamanaReddy0M
Loading

Closes #798.

before:

$ go run main.go -d nvidia.com

               __    _____           __         
   _______  __/ /_  / __(_)___  ____/ /__  _____
  / ___/ / / / __ \/ /_/ / __ \/ __  / _ \/ ___/
 (__  ) /_/ / /_/ / __/ / / / / /_/ /  __/ /    
/____/\__,_/_.___/_/ /_/_/ /_/\__,_/\___/_/

                projectdiscovery.io

[INF] Current subfinder version v2.6.4-dev (development)
[INF] Loading provider config from /home/vscode/.config/subfinder/provider-config.yaml
[INF] Enumerating subdomains for nvidia.com
...
[INF] Found 1968 subdomains for nvidia.com in 10 seconds 31 milliseconds

after:

$ go run main.go -d nvidia.com

               __    _____           __         
   _______  __/ /_  / __(_)___  ____/ /__  _____
  / ___/ / / / __ \/ /_/ / __ \/ __  / _ \/ ___/
 (__  ) /_/ / /_/ / __/ / / / / /_/ /  __/ /    
/____/\__,_/_.___/_/ /_/_/ /_/\__,_/\___/_/

                projectdiscovery.io

[INF] Current subfinder version v2.6.4-dev (development)
[INF] Loading provider config from /home/vscode/.config/subfinder/provider-config.yaml
[INF] Enumerating subdomains for nvidia.com
...
[INF] Found 1973 subdomains for nvidia.com in 12 seconds 851 milliseconds

@dogancanbakir dogancanbakir self-assigned this Sep 13, 2023
@dogancanbakir dogancanbakir linked an issue Sep 13, 2023 that may be closed by this pull request
Domains with capitals are not discovered #798
Closed
RamanaReddy0M
RamanaReddy0M approved these changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@RamanaReddy0M RamanaReddy0M left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

 ✗ go run main.go -d nvidia.com


               __    _____           __         
   _______  __/ /_  / __(_)___  ____/ /__  _____
  / ___/ / / / __ \/ /_/ / __ \/ __  / _ \/ ___/
 (__  ) /_/ / /_/ / __/ / / / / /_/ /  __/ /    
/____/\__,_/_.___/_/ /_/_/ /_/\__,_/\___/_/

                projectdiscovery.io

[INF] Current subfinder version v2.6.4-dev (development)
[INF] Loading provider config from /Users/ramana/.config/subfinder/provider-config.yaml
[INF] Enumerating subdomains for nvidia.com
...
hqemgatev15.nvidia.com
rmsession.datamonst.egx.nvidia.com
cf-behavior-test.ee.nvgs.nvidia.com
origin-stmos.nvidia.com
cz-admin-shield.nvidia.com
[INF] Found 1973 subdomains for nvidia.com in 20 seconds 358 milliseconds

@ehsandeep ehsandeep merged commit 188d0b6 into dev Sep 21, 2023
8 checks passed
@ehsandeep ehsandeep deleted the refactor_extractor branch September 21, 2023 09:42
@ehsandeep ehsandeep added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RamanaReddy0M RamanaReddy0M RamanaReddy0M approved these changes

@ehsandeep ehsandeep ehsandeep approved these changes

Assignees

@dogancanbakir dogancanbakir

Labels
Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Domains with capitals are not discovered
3 participants
@dogancanbakir @ehsandeep @RamanaReddy0M