Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup migration code #941

Merged
merged 4 commits into from
Aug 18, 2023
Merged

Cleanup migration code #941

merged 4 commits into from
Aug 18, 2023

Conversation

dogancanbakir
Copy link
Member

Closes #930.

@dogancanbakir dogancanbakir self-assigned this Aug 16, 2023
@dogancanbakir dogancanbakir changed the base branch from main to dev August 16, 2023 12:05
v2/pkg/runner/options.go Outdated Show resolved Hide resolved
Copy link
Member

@Mzack9999 Mzack9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

$ rm -rf /Users/xxx/.config/subfinder/provider-config.yaml 
$ echo scanme.sh | go run .
...
$ file /Users/xxx/.config/subfinder/provider-config.yaml
/Users/xxx/.config/subfinder/provider-config.yaml: ASCII text

@Mzack9999 Mzack9999 added the Type: Maintenance Updating phrasing or wording to make things clearer or removing ambiguity. label Aug 18, 2023
@Mzack9999 Mzack9999 merged commit e4b5789 into dev Aug 18, 2023
8 checks passed
@Mzack9999 Mzack9999 deleted the cleanup_migration_code branch August 18, 2023 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Maintenance Updating phrasing or wording to make things clearer or removing ambiguity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleanup - Provider migration code
2 participants