Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move wifi NAN feature to mixins options #2502

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

gowthambabu92
Copy link
Contributor

@gowthambabu92 gowthambabu92 commented Jun 18, 2024

NAN and hotspot cannot work simultaneously, as both wants the wifi chip tp be STA and AP simultaneously.

Move NAN to mixins options, whenever needed we can enable them in mixins.spec and validate.

Tests done:

  1. Build nan=false
  2. Flash BM, check wifi and hotspot on success
  3. Build nan=true
  4. Flash BM, #>pm list features | grep wifi
  5. Check wifi aware is listing in features list
  6. Verify wifi aware service is running from logcat

@sysopenci
Copy link

Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web for more details.

@sysopenci
Copy link

FAILURE: Android CI has completed Engineering Build for this issue.Please check the linked Tracked-On issue/Android CI Web for more details.

NAN and hotspot cannot work simultaneously, as both wants the
wifi chip tp be STA and AP simultaneously.

Move NAN to mixins options, whenever needed we can enable them in
mixins.spec and validate.

Tests done:
1. Build nan=false
2. Flash BM, check wifi and hotspot on success
3. Build nan=true
4. Flash BM, #>pm list features | grep wifi
5. Check wifi aware is listing in features list
6. Verify wifi aware service is running from logcat

Signed-off-by: Gowtham Anandha Babu <[email protected]>
@sysopenci
Copy link

Improper Commit Message
Tracked on not found in commit message,
make sure Tracked-On: Jira-ticket is present.

@sysopenci
Copy link

Expected syntax:
Commit message one-line summary

  Extra paragraphs can be added here.

  Longer description that explains the problem / solution
  or whatever that needs to be said

  It can contain
    multiple lines
    multiple paragraphs
    blank lines
    references

  But each paragraph must be followed by a blank line

  However, you need to keep the 'Tracked-On', 'Change-Id',
  'Signed-off-by', ..., fields in the **lastest** paragraph of
  the commit message.

  Change-Id: I9e58f79c7faf7f0edb9792e8b5322ab161331141
  Tracked-On: https://jira.server.ext/browse/PROJECTA-123
  Signed-off-by: Developer Name <[email protected]>

@sysopenci sysopenci added the Stale Stale label for inactive open prs label Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants