New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing uninitialized variable coverity issue #179

Merged

sysopenci merged 1 commit into projectceladon:celadon/u/mr0/master from devath1x:bt_static_code_anlysis1

Sep 19, 2024

+1 −1

devath1x commented Sep 10, 2024

has_died_ is not initialized in this constructor nor in any functions that it calls

Initialized has_died_ in constructor

Tested:
BT on/off
Connect phone, play music
HFP call
File transfer
CtsBluetoothTestCases

Tracked-On: OAM-123193

sysopenci added Valid commit message Pending Developer Approval Pending PR Review Engineering Build Not Started labels

sysopenci requested review from balajim001, feijiang1, gkdeepa and JeevakaPrabu

September 10, 2024 03:23

sysopenci commented Sep 10, 2024

Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web for more details.

sysopenci commented Sep 10, 2024

FAILURE: Android CI has completed Engineering Build for this issue.Please check the linked Tracked-On issue/Android CI Web for more details.

sysopenci added Engineering Build Failed and removed Engineering Build Not Started labels

sysopenci commented Sep 17, 2024

Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web for more details.

devath1x force-pushed the bt_static_code_anlysis1 branch from b3c044e to 4615ec5 Compare

September 17, 2024 06:36

sysopenci added Valid commit message and removed Valid commit message labels

sysopenci requested a review from dyang23

September 17, 2024 06:39

sysopenci commented Sep 17, 2024

Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web for more details.

sysopenci commented Sep 17, 2024

FAILURE: Android CI has completed Engineering Build for this issue.Please check the linked Tracked-On issue/Android CI Web for more details.

devath1x force-pushed the bt_static_code_anlysis1 branch from 4615ec5 to 65d7fc4 Compare

September 17, 2024 07:01

devath1x changed the title ~~Fixing medium issue in static code analysis~~ Fixing uninitialized variable coverity issue

sysopenci added Valid commit message and removed Valid commit message labels

Contributor

gowthambabu92 commented Sep 17, 2024

LGTM
Tested and validated on hardware.

sysopenci commented Sep 17, 2024

Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web for more details.

sysopenci commented Sep 17, 2024

FAILURE: Android CI has completed Engineering Build for this issue.Please check the linked Tracked-On issue/Android CI Web for more details.

devath1x force-pushed the bt_static_code_anlysis1 branch from 65d7fc4 to db64ce9 Compare

September 17, 2024 08:39

sysopenci added Valid commit message and removed Valid commit message labels

sysopenci commented Sep 17, 2024

Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web for more details.


          Fixing uninitialized variable coverity issue

db64ce9

has_died_ is not initialized in the constructor nor
in any functions that it calls

Initialized has_died_ in constructor

Tested:
BT on/off --> 10 times
Connect phone, play music -> 10 times
HFP call --> 10 times
File transfer -> working
CtsBluetoothTestCases -> passing

Tracked-On: OAM-123193
Signed-off-by: devath1x <[email protected]>
Signed-off-by: Gowtham Anandha Babu <[email protected]>

shyjumon-n approved these changes

View reviewed changes

shyjumon-n left a comment

LGTM

sysopenci commented Sep 17, 2024

FAILURE: Android CI has completed Engineering Build for this issue.Please check the linked Tracked-On issue/Android CI Web for more details.

sysopenci commented Sep 17, 2024

SUCCESS: Android CI has completed Engineering Build for this issue.Please check the linked Tracked-On issue/Android CI Web for more details.

sysopenci added Engineering Build Successful Developer Approved and removed Engineering Build Failed Pending Developer Approval labels

balajim001 approved these changes

View reviewed changes

balajim001 left a comment

LGTM

sysopenci added PR approved and removed Pending PR Review labels

sysopenci removed request for JeevakaPrabu, gkdeepa, feijiang1 and dyang23

September 19, 2024 14:21

sysopenci commented Sep 19, 2024

Android CI has started MERGE Build for this pr ,Please check the linked Tracked-On issue/Android CI Web for more details.

sysopenci merged commit bc9c17b into projectceladon:celadon/u/mr0/master

15 checks passed

sysopenci commented Sep 19, 2024

Android CI has completed MERGE Build for this pr, build is SUCCESS. Please check the linked Tracked-On issue/Android CI Web for more details. For Binaries: /cactus-absp-or-local/celadon_umr0_master-merge/114

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Developer Approved Engineering Build Successful PR approved Valid commit message