Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coverity fixes for external camera and remote camera #177

Merged
merged 1 commit into from
Sep 10, 2024
Merged

coverity fixes for external camera and remote camera #177

merged 1 commit into from
Sep 10, 2024

Conversation

shivasku82
Copy link
Contributor

No description provided.

@shivasku82
coverity fixes for external camera and remote camera
0007d63 
Addressed high priority coverity issues related to
resource leaks, string not-null termination etc.

Test done:

1. Flashed the image with fixes
2. Open AOSP camera and Multicamera app
3. Able to capture and record with both apps

Tracked-On: OAM-124500
Signed-off-by: tdivy20 <[email protected]>
Signed-off-by: shivasku82 <[email protected]>
@sysopenci
Copy link

Expected syntax:
Commit message one-line summary

  Extra paragraphs can be added here.

  Longer description that explains the problem / solution
  or whatever that needs to be said

  It can contain
    multiple lines
    multiple paragraphs
    blank lines
    references

  But each paragraph must be followed by a blank line

  However, you need to keep the 'Tracked-On', 'Change-Id',
  'Signed-off-by', ..., fields in the **lastest** paragraph of
  the commit message.

  Change-Id: I9e58f79c7faf7f0edb9792e8b5322ab161331141
  Tracked-On: https://jira.server.ext/browse/PROJECTA-123
  Signed-off-by: Developer Name <[email protected]>

@sysopenci sysopenci added Pending Developer Approval Pending Developer Approval Pending PR Review Pending PR Review Engineering Build Not Started Engineering Build Not Started labels Sep 9, 2024
@sysopenci sysopenci added Developer Approved and removed Pending Developer Approval Pending Developer Approval labels Sep 9, 2024
@sysopenci
Copy link

Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web for more details.

@sysopenci
Copy link

SUCCESS: Android CI has completed Engineering Build for this issue.Please check the linked Tracked-On issue/Android CI Web for more details.

@sysopenci sysopenci added Engineering Build Successful Engineering Build Successful and removed Engineering Build Not Started Engineering Build Not Started labels Sep 9, 2024
balajim001
balajim001 approved these changes Sep 9, 2024
View reviewed changes
Copy link

@balajim001 balajim001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sysopenci sysopenci added PR approved and removed Pending PR Review Pending PR Review labels Sep 9, 2024
@sysopenci sysopenci added the Integration Approved Integration Approved label Sep 10, 2024
@sysopenci
Copy link

Android CI has started MERGE Build for this pr ,Please check the linked Tracked-On issue/Android CI Web for more details.

@sysopenci
Copy link

Android CI has completed MERGE Build for this pr, build is FAILURE. Please check the linked Tracked-On issue/Android CI Web for more details.

@sysopenci
Copy link

Android CI has started MERGE Build for this pr ,Please check the linked Tracked-On issue/Android CI Web for more details.

@sysopenci sysopenci merged commit e05c9eb into projectceladon:celadon/u/core Sep 10, 2024
18 checks passed
@sysopenci
Copy link

Android CI has completed MERGE Build for this pr, build is SUCCESS. Please check the linked Tracked-On issue/Android CI Web for more details. For Binaries: /cactus-absp-or-local/celadon_u_core-merge/10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balajim001 balajim001 balajim001 approved these changes

Assignees
No one assigned
Labels
Developer Approved Engineering Build Successful Engineering Build Successful Integration Approved Integration Approved PR approved Valid commit message
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shivasku82 @sysopenci @balajim001