Coverity fixes for ExternalCamera and RemoteCamera #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shivasku82
reviewed
Aug 29, 2024
| @@ -798,7 +798,8 @@ Status ExternalCameraDeviceSession::switchToOffline( | |||
| native_handle_t* handle = native_handle_create(/*numFds*/ 1, /*numInts*/ 0); | |||
| handle->data[0] = buffer.acquireFence; | |||
| outputBuffer.releaseFence = android::makeToAidl(handle); | |||
| } | |||
| @@ -1827,7 +1829,8 @@ Status ExternalCameraDeviceSession::processCaptureResult(std::shared_ptr<HalRequ | |||
| native_handle_t* handle = native_handle_create(/*numFds*/ 1, /*numInts*/ 0); | |||
| handle->data[0] = req->buffers[i].acquireFence; | |||
| result.outputBuffers[i].releaseFence = ::android::makeToAidl(handle); | |||
| } | |||
| @@ -248,7 +250,8 @@ Status ExternalCameraOfflineSession::processCaptureRequestError( | |||
| native_handle_t* handle = native_handle_create(/*numFds*/ 1, /*numInts*/ 0); | |||
| handle->data[0] = req->buffers[i].acquireFence; | |||
| outputBuffer.releaseFence = makeToAidl(handle); | |||
| } | |||
| native_handle_delete(handle); | |||
| @@ -131,10 +131,10 @@ HandleImporter RemoteCameraDeviceSession::sHandleImporter; | |||
|
|
|||
| void *RemoteDataRecvThreadFun(void *argv) | |||
| { | |||
| ALOGI(LOG_TAG " %s: Thread is running", __FUNCTION__); | |||
| ALOGI(LOG_TAG " %s: divy1 Thread is running", __FUNCTION__); | |||
| struct pollfd fd; | ||
| int event; | ||
| uint8_t *fBuffer = nullptr; | ||
| uint8_t *fBuffer = nullptr; |
| @@ -163,10 +163,14 @@ void *RemoteDataRecvThreadFun(void *argv) | |||
| size_header = recv(parentHandle->mFd, (char *)&buffer_header, sizeof(camera_header_t), 0); | |||
| if(buffer_header.type == CAMERA_DATA){ | |||
| size_pending = (size_t)buffer_header.size; | |||
| if(fBuffer != nullptr) { | |||
| if (fBuffer == NULL) { | ||
| ALOGE(LOG_TAG "%s: buffer allocation failed: %d ", __FUNCTION__, __LINE__); | ||
| } | ||
| if (fBuffer == NULL) { |
There was a problem hiding this comment.
its better to return if memory allocation fail
Addressed high priority coverity issues related to resource leaks, string not-null termination etc. Test done: 1. Flashed the image with fixes 2. Open AOSP camera and Multicamera app 3. Able to capture and record with both apps Tracked-On: OAM-122344 Signed-off-by: tdivy20 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressed high priority coverity issues related to resource leaks, string not-null termination etc.
Tests done:
Tracked-On: OAM-122344