[SMR0] Fixed the issue that sw codec fails to validate 10-bit type buffer #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#67 |
zhangyichix
force-pushed
the
validateBufferSize_2_smr0
branch
from
8f83489
to
a42491b
Compare
zhangyichix
changed the title
…ffer The function validateBufferSize fails when sw codec allocates buffer with HAL_PIXEL_FORMAT_YCBCR_P010. The reason is that the pixel format will be converted to drm format for allocating buffer, then the format of the handle is assigned to HAL_PIXEL_ format type with i915_private_invert_format, but the descriptor.format is still the pixel format, they must be different when checked in validateBufferSize. So we check the format type after uniformly converting the pixel/HAL format to drm format. Tracked-On: OAM-112372 Signed-off-by: zhangyichix <[email protected]>
feijiang1
approved these changes
Sep 25, 2023
sysopenci
reviewed
Sep 28, 2023
sysopenci
reviewed
Sep 28, 2023
There was a problem hiding this comment.
PR integrated into 'preintegration' builder
More details, logs, and binaries: /absp/builders/celadon_smr0_master-preintegration/builds/686
Done by "Jiang, Fei" [email protected]
sysopenci
reviewed
Sep 28, 2023
There was a problem hiding this comment.
PR integrated into 'premerge' builder
More details, logs, and binaries: /absp/builders/celadon_smr0_master-premerge/builds/407
Done by "Jiang, Fei" [email protected]
sysopenci
merged commit 78f4646
into
projectceladon:celadon/s/mr0/master
10 checks passed
sysopenci
reviewed
Sep 28, 2023
There was a problem hiding this comment.
cactus finished building and testing your changes
It was requested for merge by "Jiang, Fei" [email protected]
so we merge it. Thanks for your contribution.
more details, logs, and binaries: /absp/builders/celadon_smr0_master-mergerequest/builds/402
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function validateBufferSize fails when sw codec allocates buffer with HAL_PIXEL_FORMAT_YCBCR_P010. The reason is that the pixel format will be converted to drm format for allocating buffer, then the format of the handle is assigned to HAL_PIXEL_ format type with i915_private_invert_format, but the descriptor.format is still the pixel format, they must be different when checked in validateBufferSize. So we check the format type after uniformly converting the pixel/HAL format to drm format.
Tracked-On: OAM-112372