This repository has been archived by the owner on Jan 10, 2023. It is now read-only.
Resolve VNDK, Treble build error #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BZ: 171159 Semaphores are useful for multi-thread programming. This patch introduces the Semaphore class which wraps a POSIX semaphore. Change-Id: I7a5c0a6a3756525a758e949cd7a0dc2ba31eff35 Signed-off-by: Thomas Cahuzac <[email protected]> Reviewed-on: https://android.intel.com/166203
BZ: 178631 AUDIOCOMMS_ASSERT calls a macros in lower_snake_case while it is declare in UPPER_SNAKE_CASE. Fix this typo. Change-Id: I18efedcfe2690c2a2388e73c29643642335f29c4 Signed-off-by: Renaud de Chivre <[email protected]>
BZ: 177489 Checkfile script of all AudioComms projects execute a "base" script located in a private repo. When executed in the context of an external delivery, this redirection fails and the script displays an unexpected error message. This patch prevents error message from being displayed and replaces it by an info message. Change-Id: I4e372ab7712a5df60374cd33ec13a5df787b15ee Signed-off-by: Renaud de Chivre <[email protected]>
BZ: 180283 Change license header to BSD and update years. Change-Id: I95f17082830d3fcf69d65c55fee526d5a363c27b Signed-off-by: Renaud de Chivre <[email protected]>
BZ: 180300 This patch updates the remote parameter library API due to remote parameter plugin needs. It concerns for example the string template specialization, the homogeneous API for each specialization. Until now, only integer, boolean and string are supported as remote parameter. Change-Id: I4cd944b60ec09b0d4d343f6931a3d7cd513a8613 Signed-off-by: Francois Gaffie <[email protected]>
BZ: 180300 This patch adds the remote parameter plugin. This plugin is acting a a remote parameter proxy to control parameters handled by a remote parameter server. Change-Id: Iae73b60845d7260861c4a5aba13360ab17fe9270 Signed-off-by: Francois Gaffie <[email protected]>
BZ: 180300 This patch updates the remote parameter library with new unified coding style. Change-Id: I5d381480ceed2b57430d56ae328bdfb0792f135e Signed-off-by: Francois Gaffie <[email protected]>
BZ: 180300 This patch introduces the gcov flush object for host. Upon deletion, this object forces a flush of gcov counters. Change-Id: I65909ebbc0d41ba6407a8026f8eec1b3a622c2d6 Signed-off-by: Francois Gaffie <[email protected]>
BZ: 185787 Automatic build of the plugin and its dependancies does not work. This patch solves the issue by removing dead operation in the makefile. Change-Id: I137090326d35269f28c5d715caed3415f070f87e Signed-off-by: Francois Gaffie <[email protected]>
BZ: 185787 Remote Parameter plugin functional tests fail with seg fault. This patch fixes the fonctional tests. Change-Id: If454e966fdbd3825b0b59ecdad94bc07c410870d Signed-off-by: Francois Gaffie <[email protected]>
BZ: 185787 Many makefiles still use compilation flags. Build system is now clever enougth not to compile the module that are not required for a given variant. This patches removes compile flags and unused variable in remote parameter and gcov flush components. Change-Id: I11d389dfc43247a8e836ce037bf7434e1f19f8f5 Signed-off-by: Francois Gaffie <[email protected]>
BZ: 185787 Remote Parameter server starts successfully even if it could not start the event thread. This patches fixes the issue and align the stop strategy on the start strategy, e.g. do not do action if already in the good state. Change-Id: Idff0ce3fe9658fa419ba4e935a68cf62955e1b04 Signed-off-by: Francois Gaffie <[email protected]>
BZ: 185787 The remote parameter server has inconsistent checks upon the thread context. This patch aligns the code with the doxygen, e.g. adding parameter is allowed only if the server is not started. Change-Id: I466a601cde8d6e788aa275d47a2b8d8f8007591d Signed-off-by: Francois Gaffie <[email protected]>
BZ: 185787 Dead code within remote parameter not cleaned. This patch removes the unused IRemoteParameter interface since template version is provided. Change-Id: I91a884907b92012f12ecfba94b9bf3965f9367d2 Signed-off-by: Francois Gaffie <[email protected]>
BZ: 185787 The security check on remote parameter based on gid has very few chances to work. This patch temporary removes the security check. A new mechansim will be provided in a separated patch. Change-Id: I46bf68d823c265265a4af989d22831ee8423c9f9 Signed-off-by: Francois Gaffie <[email protected]>
BZ: 186198 Assert messages were not displayed into logcat. This patchs makes them displayed. Change-Id: I6c8f3cf4b9bba8c4542ef47071509c4b57ee63ff Signed-off-by: Thomas Cahuzac <[email protected]>
…lder BZ: 184301 The remote parameter plugin makes the external build fail because it is located in a public folder (currently all the parameter framework plugins must be private). This patch removes the plugin from the utilities project, it will be added into the parameter-framework folder (which is private) in a subsequent patch. This patch is workaround because the definitive plugin location will be known when the decision "parameter framework plugins can be public or not" will be made. Change-Id: I8f12250d69f312991f31a6091ae0ce553d774e53 Signed-off-by: Thomas Cahuzac <[email protected]>
BZ: 176178 This allows calling convertTo() on a double. Change-Id: I2f0b5bbe928c716d53fd0fdf29e44af0e66b84f3 Signed-off-by: David Wagner <[email protected]>
BZ: 176178 The stlport behaviour differs from the GNU STL regarding overflows: instead of failing to convert, it converts values larger than max() to Infinity. The specialization takes this into account and returns an error if the converted value is +/-Infinity. It also returns an error if a "NaN" (Not A Number) is returned by the STL. Change-Id: I4ecc21aa109dffc2867d4e3b296181bd287df495 Signed-off-by: David Wagner <[email protected]>
BZ: 189085 This patch updates the remote parameter library with the latest coding rules adopted. Change-Id: I55eb66802d265aba939b9f013f04c832edf32226 Signed-off-by: Francois Gaffie <[email protected]>
BZ: 189085 No security check is done in Remote Parameter. This patch implements a credential check based on the identifier name of the peer connected to the socket. Change-Id: Iad34ef8883dda07e90418f411f80ad22e824c787 Signed-off-by: Francois Gaffie <[email protected]>
BZ: 189085 Constructors can fail silently. This patch implements 2-steps constructor and adds few logs to detect runtime errors. Those errors are handled by using the standard posix errors messages and errno. Change-Id: I9128dbb4a79391f14dbb035745757adb0ff37c4d Signed-off-by: Renaud de Chivre <[email protected]>
BZ: 202797 This patch formats the code of the convert library to match the coding rules. Change-Id: I39af34358989784dc36f1a70a03abe64c58f57ba Signed-off-by: Francois Gaffie <[email protected]>
BZ: 202797 It may be useful in case of templates to have a "dummy" conversion from string to string supported. This patch adds this dummy conversion. Change-Id: Iba361a5e813dd0d9d0c2dc22e38dd3fdabcc42ab Signed-off-by: Francois Gaffie <[email protected]>
BZ: 202797 This patch adds the coverage to host version of convert library and update the module tags of host version from optional to tests. Change-Id: I49767a519afb489cb385ec58e81ba5e92035af33 Signed-off-by: Francois Gaffie <[email protected]>
BZ: 202797 This patch changes convertion to conversion. Change-Id: I223430d4c0b82d6179030820c89de61ef6f53aef Signed-off-by: Francois Gaffie <[email protected]>
BZ: 202797 Many SW components implement their own toString utility. It is high time this utility were factorized. This patch implements extends the convertTo API to support both source and destination as template parameters. Change-Id: I09e86a0c7809e4b9f61f57d77e3d5c90a8a9bf66 Signed-off-by: Francois Gaffie <[email protected]>
BZ: 202797 This patch introduces the gcov flush utility library on target with the same name as used on host in order to use the quality hook regardless of the type of build (host / target). It keeps the flush version using property only on target as property lib dependancy is not available on host. Change-Id: If5c88da470b4559f0e9b5fd9d2185e62b191c1ad Signed-off-by: Francois Gaffie <[email protected]>
BZ: 202797 This patch updates the makefiles of the remote parameter libraries to make use of coverage hooks. Change-Id: I9378cbd1dfa6bf50e9e5746103a68472c709da5b Signed-off-by: Francois Gaffie <[email protected]>
BZ: 210780 Result is cross lib as it aims to be used in API. This patch moves the result in its own lib. Change-Id: I5e1e1a261cefa9066f76ebdb37f2420c8a89842d Origin-Change-Id: I66614a7b2e62965253d3744c73847aca4685de44 Signed-off-by: Kevin Rocard <[email protected]> Reviewed-on: http://android.intel.com:8080/152271
…/audio/master' into android/l/mr1/master git log --pretty=format:'%h %ad | %s%d [%an]' remotes/origin/android/l/mr1/master..remotes/origin/abt/topic/gmin/l-dev/mr1/audio/master: 3307409 Mon Sep 8 14:36:59 2014 +0200 | Add a header with intel specific keys & values definition (origin/abt/topic/gmin/l-dev/mr1/audio/master, m/abt/topic/gmin/l-dev/mr1/audio/master) [Francois Gaffie] git diff --stat remotes/origin/android/l/mr1/master..HEAD: include/IntelAudioParameters.hpp | 46 ++++++++++++++++++++++++++++++++++++++++ 1 file changed, 46 insertions(+) Change-Id: Iaa4a9b191b90de697c1684b015fd0232bcb6688e Tracked-On: https://jira01.devtools.intel.com/browse/GMINL-12412 Signed-off-by: Guillaume Zajac <[email protected]>
Starting with M, stlport should no longer be used. It is only present in the tree to enable a set of whitelisted devices which have binaries that have not been updated. Tracked-On: https://jira01.devtools.intel.com/browse/OAM-23 Change-Id: Id20284b2e415366c2e70fbaba9977015cd6d9a76 Reviewed-on: https://android.intel.com:443/387898
It reverts commit 3307409. These keys & values definition are now defined in header files located in a BSP project: - hardware/intel/audio/hal/utilities/parameter/include/KeyValuePairs.hpp - hardware/intel/audio/hal/utilities/parameter/include/Parameters.hpp Change-Id: I3659f582f892b6abe03a25649968c5618824e1bd Tracked-On: https://jira01.devtools.intel.com/browse/GMINL-11885 Signed-off-by: Riadh Khaldi <[email protected]> Reviewed-on: https://android.intel.com:443/388492
Change-Id: Ia2f0466fc1ec14c4a2ef167ecde4d14bfe493215 Tracked-On: https://jira01.devtools.intel.com/browse/CACTUS-3235
…aster' into android/l/mr1/master git log --pretty=format:"%h %ad | %s%d [%an]" origin/android/l/mr1/master..origin/abt/topic/gmin/l-dev/mr1/audio/master: a6d7c8b Fri Mar 27 09:12:28 2015 +0100 | Fix Log.hpp for clang compilation. (origin/abt/topic/gmin/l-dev/mr1/audio/master) [Jules Clero] git diff --stat origin/android/l/mr1/master..HEAD: include/utilities/Log.hpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) Change-Id: I86d507fc7fd0fdf0a404b428957c1d7aa91954dc Tracked-On: https://jira01.devtools.intel.com/browse/GMINL-6201 Signed-off-by: Lynette Layne <[email protected]> Reviewed-on: https://android.intel.com:443/392794
Change-Id: I2b971cf23c55c33a0f28b3a0722dce5df4549776 Tracked-On: https://jira01.devtools.intel.com/browse/CACTUS-3894
…aster' into android/l/mr1/master git log --pretty=format:"%h %ad | %s%d [%an]" origin/android/l/mr1/master..origin/abt/topic/gmin/l-dev/mr1/audio/master: 2be8010 Tue Apr 14 08:56:43 2015 +0200 | Add Host compilation support of utilities (origin/abt/topic/gmin/l-dev/mr1/audio/master) [François Gaffie] b0c97ae Thu Apr 18 15:27:26 2013 +0200 | [Utilities] Have a unit-testable Property library [Sebastien Gonzalve] c190b78 Mon Jul 27 17:12:24 2015 +0200 | Remove useless AudioCommsAssert.h [Sebastien Gonzalve] git diff --stat origin/android/l/mr1/master..HEAD: convert/Android.mk | 31 ++- convert/convert.hpp | 384 +-------------------------- convert/include/convert/convert.hpp | 364 +++++++++++++++++++++++++ gcov_flush_with_prop/Android.mk | 13 +- gcov_flush_with_prop/GcovFlushWithProp.cpp | 6 +- include/AudioCommsAssert.h | 100 ------- include/Observable.hpp | 4 +- naive_tokenizer/Android.mk | 2 +- property/Android.mk | 73 ++--- property/Property.cpp | 84 ++---- property/Property.h | 41 --- property/PropertyBase.cpp | 74 ------ property/PropertyBase.h | 49 ---- property/PropertyTemplateInstanciations.h | 7 - property/getProp | 3 - property/include/property/Property.hpp | 413 +++++++++++++++++++++++++++++ property/simulation/utils/Log.h | 41 --- 17 files changed, 884 insertions(+), 805 deletions(-) Change-Id: I2b9963c54166f94fee2ae40da092999b40b19f70 Tracked-On: https://jira01.devtools.intel.com/browse/GMINL-6417 Tracked-On: https://jira01.devtools.intel.com/browse/GMINL-14747 Signed-off-by: Eric Sanchez <[email protected]> ## Don't forget to add a JIRA URL to the Tracked-On metadata! ## https://wiki.ith.intel.com/display/CACTUS/Patch+requirements+check ## url should be in the form: ## Tracked-On: https://jira01.devtools.intel.com/browse/<PROJ>-<NUMB> ## Several Tracked-On lines are allowed ## you can fully prefill your Tracked-On commits using environment variable: ## export CURRENT_TRACKED_ON=https://jira01.devtools.intel.com/browse/<PROJ>-<NUMB> ## Reviewed-on: https://android.intel.com:443/399990
git log --pretty=format:"%h %ad | %s%d [%an]" origin/android/l/mr1/master..origin/abt/topic/gmin/l-dev/mr1/audio/master: 2be8010 Tue Apr 14 08:56:43 2015 +0200 | Add Host compilation support of utilities (origin/abt/topic/gmin/l-dev/mr1/audio/master) [François Gaffie] b0c97ae Thu Apr 18 15:27:26 2013 +0200 | [Utilities] Have a unit-testable Property library [Sebastien Gonzalve] c190b78 Mon Jul 27 17:12:24 2015 +0200 | Remove useless AudioCommsAssert.h [Sebastien Gonzalve] git diff --stat origin/android/l/mr1/master..HEAD: convert/Android.mk | 31 ++- convert/convert.hpp | 384 +-------------------------- convert/include/convert/convert.hpp | 364 +++++++++++++++++++++++++ gcov_flush_with_prop/Android.mk | 13 +- gcov_flush_with_prop/GcovFlushWithProp.cpp | 6 +- include/AudioCommsAssert.h | 100 ------- include/Observable.hpp | 4 +- naive_tokenizer/Android.mk | 2 +- property/Android.mk | 73 ++--- property/Property.cpp | 84 ++---- property/Property.h | 41 --- property/PropertyBase.cpp | 74 ------ property/PropertyBase.h | 49 ---- property/PropertyTemplateInstanciations.h | 7 - property/getProp | 3 - property/include/property/Property.hpp | 413 +++++++++++++++++++++++++++++ property/simulation/utils/Log.h | 41 --- 17 files changed, 884 insertions(+), 805 deletions(-) Change-Id: I2b9963c54166f94fee2ae40da092999b40b19f70 Tracked-On: https://jira01.devtools.intel.com/browse/OAM-940 Tracked-On: https://jira01.devtools.intel.com/browse/OAM-942 Signed-off-by: Eric Sanchez <[email protected]> Reviewed-on: https://android.intel.com:443/399990 Reviewed-on: https://android.intel.com:443/402394
This patch tags the host components as optional instead of test. Change-Id: I34cacde96a8c102373113ee2be21a63fd09d6539 Tracked-On: https://jira01.devtools.intel.com/browse/GMINL-14461 Signed-off-by: Miguel Gaio <[email protected]> Reviewed-on: https://android.intel.com:443/409547
This patch adds an helper class to abstract the usage of pthread_cond_t tightly coupled with Mutex helper class. Change-Id: I2ae751e64f11bb56862c931a39579ebe6b28e534 Tracked-On: https://jira01.devtools.intel.com/browse/GMINL-14461 Signed-off-by: Thomas Cahuzac <[email protected]> Reviewed-on: http://android.intel.com:8080/150053 Reviewed-by: Gonzalve, Sebastien <[email protected]> Reviewed-by: Soulard, Mathieu <[email protected]> Reviewed-on: https://android.intel.com:443/409548
Change-Id: I1e1c5dda02515a0b850147936665a80119fe861d Tracked-On: https://jira01.devtools.intel.com/browse/OAM-1270 Signed-off-by: Safa Boumaiza <[email protected]>
Android M switched to CLANG on M dessert. This patch fixes host build issues met on Android M. Change-Id: I3ce3b3bb548ff6e571c7c83adfba4e9ca9327dbd Tracked-On: https://jira01.devtools.intel.com/browse/OAM-7451 Signed-off-by: François Gaffie <[email protected]> Reviewed-on: https://android.intel.com:443/429049
AudioComms Utilities NonCopyable class has conflict with PFW 3.2.3 one. Rename AudioComms Utilities NonCopyable file to avoid conflict. Change-Id: Icc5b0e40b91150fe9c2b3bd9781711378fac5691 Tracked-On: https://jira01.devtools.intel.com/browse/OAM-6938 Signed-off-by: Khaled Ben Amor <[email protected]> Reviewed-on: https://android.intel.com:443/466159
This patch corrects following compilation error: dependent nested name specifier 'Append<Data>::' for friend class declaration is not supported Change-Id: Ia19d8c3ad4aa2ea4dc70e6f06f1b92f05a0f72ff Tracked-On: https://jira01.devtools.intel.com/browse/OAM-17022 Signed-off-by: Khaled Ben Amor <[email protected]> Reviewed-on: https://android.intel.com:443/481695
Change-Id: I719dbca8041f3704499b7e1a6668fe75710331db
TinyXML is deprecated and should no more be used. This patch change TinyXML by TinyXML2. Change-Id: Ie06c0b90bb3b8b2c79172600a001d9b18fb9ec05 Tracked-On: https://jira01.devtools.intel.com/browse/OAM-24744 Signed-off-by: Khaled Ben Amor <[email protected]> Reviewed-on: https://android.intel.com:443/485493
Change-Id: Ib0010984117961fbe4b5d3cd09db7539d0335826 Tracked-On: https://jira01.devtools.intel.com/browse/OAM-30576 Reviewed-on: https://android.intel.com:443/499244
TinyXML is deprecated and should no more be used. This patch change TinyXML by TinyXML2. Change-Id: Ie06c0b90bb3b8b2c79172600a001d9b18fb9ec05 Tracked-On: https://jira01.devtools.intel.com/browse/OAM-24744 Signed-off-by: Khaled Ben Amor <[email protected]> Reviewed-on: https://android.intel.com:443/485493
This patch is disabling tests due to N migration Signed-off-by: Sebastien Guiriec <[email protected]>
Fix compilation issue after N migration Signed-off-by: Sebastien Guiriec <[email protected]>
As part of public push rename legacy AudioComms prefix to AudioUtilities in order to be more explicit. Signed-off-by: Sebastien Guiriec <[email protected]>
In order to remove legacy audio_comms branding the namespace is rename to audio_utilities. Jira: None Test: Build and run undr Intel Nuc. Signed-off-by: Sebastien Guiriec <[email protected]>
Renaming of audio_comms namespace to audio_utilities
Jira : None Test : Device boots to homescreen Signed-off-by: sgnanase <[email protected]>
Resolve LOCAL_USE_VNDK - build error for treble & vndk enable patches: projectceladon/device-androidia-mixins#105 projectceladon/device-androidia#137 Tracked-On: None Signed-off-by: Aravind Siddappaji <[email protected]>
sgnanase
added a commit
to projectceladon/vendor-intel-utils
that referenced
this pull request
Jan 21, 2019
Pull request from : projectceladon/hardware_intel_audiocomms_utilities#1 Tracked-On: Signed-off-by: sgnanase <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve LOCAL_USE_VNDK - build error for treble & vndk
enable patches:
projectceladon/device-androidia-mixins#105
projectceladon/device-androidia#137
Tracked-On:
Signed-off-by: Aravind Siddappaji [email protected]