Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate GPT table as read-only and read-write #218

Merged
merged 1 commit into from
Sep 29, 2024
Merged

Separate GPT table as read-only and read-write #218

merged 1 commit into from
Sep 29, 2024

Conversation

GangSecurity
Copy link
Contributor

These partition tables will be used in android flash if android image is devided into read-only image
and read-write image

Test Done:
make flashfiles to generate gpt_ro.bin gpt_rw.bin
and gpt_rw_nolic.bin
Flash these gpt tables to device through fastboot
and boot success

Tracked-On: OAM-124748

@sysopenci
Copy link

Improper Commit Message
Tracked on not found in commit message,
make sure Tracked-On: Jira-ticket is present.

@sysopenci sysopenci added Pending Developer Approval Pending Developer Approval Pending PR Review Pending PR Review Engineering Build Not Started Engineering Build Not Started labels Sep 17, 2024
@sysopenci
Copy link

Improper Commit Message
Tracked on not found in commit message,
make sure Tracked-On: Jira-ticket is present.

@GangSecurity
Separate GPT table as read-only and read-write
e1973df 
These partition tables will be used in android flash
if android image is devided into read-only image
and read-write image

Test Done:
make flashfiles to generate gpt_ro.bin gpt_rw.bin
and gpt_rw_nolic.bin
Flash these gpt tables to device through fastboot
and boot success

Tracked-On: OAM-124748
Signed-off-by: Chen, Gang G <[email protected]>
dyang23
dyang23 approved these changes Sep 23, 2024
View reviewed changes
Copy link

@dyang23 dyang23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sysopenci sysopenci added PR approved and removed Pending PR Review Pending PR Review labels Sep 23, 2024
@sysopenci sysopenci added Developer Approved and removed Pending Developer Approval Pending Developer Approval labels Sep 29, 2024
@sysopenci
Copy link

Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web for more details.

@sysopenci
Copy link

SUCCESS: Android CI has completed Engineering Build for this issue.Please check the linked Tracked-On issue/Android CI Web for more details.

@sysopenci sysopenci added Engineering Build Successful Engineering Build Successful and removed Engineering Build Not Started Engineering Build Not Started labels Sep 29, 2024
@sysopenci
Copy link

Android CI has started MERGE Build for this pr ,Please check the linked Tracked-On issue/Android CI Web for more details.

@sysopenci sysopenci merged commit 55984e9 into projectceladon:celadon/u/mr0/master Sep 29, 2024
37 checks passed
@sysopenci
Copy link

Android CI has completed MERGE Build for this pr, build is SUCCESS. Please check the linked Tracked-On issue/Android CI Web for more details. For Binaries: /cactus-absp-or-local/celadon_umr0_master-merge/142

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dyang23 dyang23 dyang23 approved these changes

Assignees
No one assigned
Labels
Developer Approved Engineering Build Successful Engineering Build Successful PR approved Valid commit message
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GangSecurity @sysopenci @dyang23