Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crashdump: add crash dump for sbl build #2031

Merged

Conversation

bhe4
Copy link
Contributor

@bhe4 bhe4 commented Sep 5, 2024

  1. add crashdump stack and heap define
  2. optimize the sbl_cd heap to 2M and static to 128K
  3. only add needed drivers in dedicated efiwrapper

CRASHDUMP_BASE_ADDRESS := 0x12800000
CRASHDUMP_HEAP_SIZE := 2097152
CRASHDUMP_STACK_SIZE := 131072

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove 1 blank line

@sysopenci
Copy link

Improper Commit Message
Jira issue not in ['bug','improvement'],
make sure jira issue is of type bug or improvement.

@sysopenci
Copy link

Expected syntax:
Commit message one-line summary

  Extra paragraphs can be added here.

  Longer description that explains the problem / solution
  or whatever that needs to be said

  It can contain
    multiple lines
    multiple paragraphs
    blank lines
    references

  But each paragraph must be followed by a blank line

  However, you need to keep the 'Tracked-On', 'Change-Id',
  'Signed-off-by', ..., fields in the **lastest** paragraph of
  the commit message.

  Change-Id: I9e58f79c7faf7f0edb9792e8b5322ab161331141
  Tracked-On: https://jira.server.ext/browse/PROJECTA-123
  Signed-off-by: Developer Name <[email protected]>

1. add crashdump stack and heap define
2. optimize the sbl_cd heap to 2M and static to 128K
3. only add needed drivers in dedicated efiwrapper

Test Done:
1. android boot
2. crashdump function works

Tracked-On: OAM-126307
Signed-off-by: Bo He <[email protected]>
Signed-off-by: Haoyu Tang <[email protected]>
@sysopenci
Copy link

Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web for more details.

Copy link
Contributor

@dyang23 dyang23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sysopenci
Copy link

SUCCESS: Android CI has completed Engineering Build for this issue.Please check the linked Tracked-On issue/Android CI Web for more details.

@sysopenci sysopenci added the Engineering Build Successful Engineering Build Successful label Oct 11, 2024
@sysopenci
Copy link

Android CI has started MERGE Build for this pr ,Please check the linked Tracked-On issue/Android CI Web for more details.

@sysopenci sysopenci merged commit 35b88d2 into projectceladon:celadon/u/mr0/master Oct 11, 2024
29 checks passed
@sysopenci
Copy link

Android CI has completed MERGE Build for this pr, build is SUCCESS. Please check the linked Tracked-On issue/Android CI Web for more details. For Binaries: /cactus-absp-or-local/celadon_umr0_master-merge/168

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants