Increase ipset creation / deletion test timeouts to allow for slow CI #8989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewdupre
added
docs-not-required
coutinhop
reviewed
Jul 8, 2024
felix/fv/ipsets_test.go
Outdated
Comment on lines
123
to
124
| // Before we rate limited deletions, this would take 80s+. Now it takes | ||
| // 10s so 20s should give some headroom. |
coutinhop
approved these changes
Jul 8, 2024
fasaxc
approved these changes
Jul 9, 2024
matthewdupre
force-pushed
the
update-ipset-rendering-timeout
branch
2 times, most recently
from
b291014
to
bc71bf7
Compare
matthewdupre
force-pushed
the
update-ipset-rendering-timeout
branch
from
bc71bf7
to
8bec16a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first of these tests failed here: #8957
CI machines don't provide good or consistent performance, so I don't believe the FVs are an appropriate place for tightly bounded performance tests.