Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace gogoprotobuf with golang protobuf #8949

Open
wants to merge 47 commits into
base: master
Choose a base branch
from

Conversation

hda2
Copy link

@hda2 hda2 commented Jun 27, 2024

Description

This change replaces gogoprotobuf with golang protobuf for Calico components. Gogoprotobuf is deprecated since Oct 2022 and is not updated. Replacing gogoprotobuf with golang protobuf can bring in new protobuf features/fixes and reduce outdated package dependencies.

To work with golang protobuf, we need (1) a calico/go-build change to include protoc in the toolchain image and (2) workaround an issue that protobuf generated types are not comparable.

Related issues/PRs

Require projectcalico/go-build#574 to be merged and pick to release branches first.

Todos

  • Tests
  • Documentation
  • Release note

Release Note

TBD

Reminder for the reviewer

Make sure that this PR has the correct labels and milestone set.

Every PR needs one docs-* label.

  • docs-pr-required: This change requires a change to the documentation that has not been completed yet.
  • docs-completed: This change has all necessary documentation completed.
  • docs-not-required: This change has no user-facing impact and requires no docs.

Every PR needs one release-note-* label.

  • release-note-required: This PR has user-facing changes. Most PRs should have this label.
  • release-note-not-required: This PR has no user-facing changes.

Other optional labels:

  • cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.
  • needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.

@CLAassistant
Copy link

CLAassistant commented Jun 27, 2024

CLA assistant check
All committers have signed the CLA.

@hjiawei hjiawei changed the base branch from protoc to master June 28, 2024 00:32
@marvin-tigera marvin-tigera added this to the Calico v3.29.0 milestone Jun 28, 2024
@marvin-tigera marvin-tigera added release-note-required Change has user-facing impact (no matter how small) docs-pr-required Change is not yet documented labels Jun 28, 2024
@hjiawei hjiawei force-pushed the hda2/protoc-update-map-keys branch from 19fd5f2 to b49a82b Compare June 28, 2024 14:50
@hda2 hda2 force-pushed the hda2/protoc-update-map-keys branch 2 times, most recently from 9bc4afd to 6d79bc0 Compare June 28, 2024 22:41
@hjiawei hjiawei changed the title Convert proto type IDs to be valid map keys Replace gogoprotobuf with golang protobuf Jul 5, 2024
lib.Makefile Outdated Show resolved Hide resolved
metadata.mk Outdated Show resolved Hide resolved
@hjiawei hjiawei force-pushed the hda2/protoc-update-map-keys branch from c2d63e5 to 4b649d2 Compare July 9, 2024 06:41
felix/calc/rule_convert.go Outdated Show resolved Hide resolved
@hjiawei hjiawei force-pushed the hda2/protoc-update-map-keys branch from 5fb90d5 to cde5c48 Compare July 11, 2024 17:33
@hjiawei hjiawei requested a review from coutinhop July 12, 2024 15:15
@hda2 hda2 requested a review from hjiawei July 12, 2024 16:07
@hjiawei hjiawei requested a review from caseydavenport July 12, 2024 16:09
@hjiawei hjiawei force-pushed the hda2/protoc-update-map-keys branch from 2afac9e to 819a2ce Compare November 15, 2024 17:58
@hjiawei
Copy link
Contributor

hjiawei commented Dec 13, 2024

/sem-approve

@hjiawei
Copy link
Contributor

hjiawei commented Dec 22, 2024

/sem-approve

Copy link
Contributor

@hjiawei hjiawei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for you contribution @hda2.

@hjiawei hjiawei self-assigned this Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required Docs not required for this change release-note-not-required Change has no user-facing impact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants