docker setup #48
Open
docker setup #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s into CCP-Red-Dragon/DockerV2
…s into CCP-Red-Dragon/DockerV2
tinkrtailor
reviewed
Oct 3, 2024
|
|
||
| ENV PATH="/root/.foundry/bin:${PATH}" | ||
|
|
||
| ENTRYPOINT ["tail", "-f", "/dev/null"] |
There was a problem hiding this comment.
Can we remove this since this is being built elsewhere?
There was a problem hiding this comment.
do we need this docker file anymore ?
tinkrtailor
reviewed
Oct 3, 2024
| @@ -12,13 +12,17 @@ PRIVATE_KEY=0xac0974bec39a17e36ba4a6b4d238ff944bacb478cbed5efcae784d7bf4f2ff80 | |||
| WORLD_ADDRESS=0x8a791620dd6260079bf849dc5567adc3f2fdc318 | |||
| PLAYER_PRIVATE_KEY=0xac0974bec39a17e36ba4a6b4d238ff944bacb478cbed5efcae784d7bf4f2ff80 | |||
|
|
|||
| #Docker RPC | |||
| RPC_URL="http://foundry:8545" | |||
There was a problem hiding this comment.
This will break the deploy:local script for those that are not on the docker network, right?
There was a problem hiding this comment.
Would it be possible to remove this from the env and pass in with a special deploy:builder_env command. I know its not the nicest approach.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.