Add an API on MTRDevice to wait for attributes to reach certain values. #36205
+579
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with |
|
PR #36205: Size comparison from e36bde7 to 2d750d1 Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
force-pushed
the
MTRDevice-value-expectation
branch
from
2d750d1
to
37d549d
Compare
|
PR #36205: Size comparison from b3223b6 to 37d549d Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
ksperling-apple
previously approved these changes
Oct 30, 2024
bzbarsky-apple
commented
Oct 31, 2024
bzbarsky-apple
force-pushed
the
MTRDevice-value-expectation
branch
from
37d549d
to
cd8e3a9
Compare
bzbarsky-apple
dismissed
ksperling-apple’s stale review
Various changes happened since the review
|
PR #36205: Size comparison from 62a4a97 to cd8e3a9 Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #36205: Size comparison from 62a4a97 to 3b360e5 Increases above 0.2%:
Full report (67 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
woody-apple
reviewed
Nov 5, 2024
| */ | ||
| - (void)cancel; | ||
|
|
||
| @property (readonly, nonatomic) NSUUID * waiterID; |
There was a problem hiding this comment.
Suggested change
| @property (readonly, nonatomic) NSUUID * waiterID; | |
| @property (readonly, nonatomic) NSUUID * UUID; |
woody-apple
reviewed
Nov 5, 2024
| * Nil will be returned if for some reason the wait could not be started | ||
| * (e.g. invalid input). | ||
| */ | ||
| - (MTRAttributeValueWaiter * _Nullable)waitForAttributeValues:(NSDictionary<MTRAttributePath *, NSDictionary<NSString *, id> *> *)values |
There was a problem hiding this comment.
If this is nullable, then it needs to return an NSError ** out param.
Per our discussion as well, I feel this is mixing two worlds together... I prefer delegate, but not a hill i'll die on :)
There was a problem hiding this comment.
So I talked about the delegate idea to some folks, and it has a drawback, which is that it makes it hard to take different actions depending on which set of attributes you were waiting for; you sort of have to define a new protocol implementation for each new thing you decide you might need, and if you need to change the behavior at runtime at all you end up having to do blocks for the behavior anyway, but now held by the delegate. So just in terms of how people want to use this API it does not feel like a great fit.
Good point about NSError**; if this stays nullable (as opposed to switching to "just assert on bad input"), I will do that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.