-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
convert some missing class. #6173
Conversation
2119a6d
to
40826f0
Compare
40826f0
to
b50fcbc
Compare
4804e90
to
40cdd6a
Compare
40cdd6a
to
7867c00
Compare
I think now it's ok to merge 👀 |
I'm late to the conversion party but just wondering why use a classes? Definitely agree we have to get away from prototype but at least in the react.js (react team moved away after using it) and node.js worlds, classes are frowned upon. It's a jarring context switch for a language that is designed to be functional. Is using classes required for this switch away from prototype? |
I would say that it's not required, but is the easiest change, since the previous code was already using classes but just using an ES5 syntax for it, so we could change to |
Oh that is smart actually. Ok fair. :) I might try to throw AI at this and see if it can blaze through. |
http://incaseofstairs.com/six-speed/ Assuming we are using Babel - Classes is a massive perf hit. 8x? wow. Also - based on Contrib docs - seems like a master Issue for ES6 conversion is missing? These one of PR's leave the conversation sporadic in closed issue comments. Should I make one? |
🚨 🚨 Please move ES6 conversion commentary over to #6371 🚨 🚨 |
Resolves #3758
More class to es6, this is a continue to #6075
Changes:
I use
p5\..*?.prototype\..*?
to find them.Screenshots of the change:
PR Checklist
npm run lint
passes