Updated README.md #1429
Merged
Updated README.md #1429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qianqianye
reviewed
Oct 30, 2023
| @@ -62,7 +62,7 @@ Once you've setup the site, type `npm run watch` to run the website. This should | |||
|
|
|||
| ## File structure | |||
|
|
|||
| * __See note about what to include in pull requests [here](https://github.com/processing/p5.js/blob/main/contributor_docs/preparing_a_pull_request.md).__ | |||
There was a problem hiding this comment.
Hey @adityadeshpande09, thanks for catching it. The new link should be https://github.com/processing/p5.js/blob/main/contributor_docs/contributor_guidelines.md#pull-requests, can you update it? Thanks.
There was a problem hiding this comment.
@adityadeshpande09 The link is still not updated, did you perhaps missed committing and pushing the latest change?
There was a problem hiding this comment.
I miss understood you before,updating ASAP.
|
Done !! |
|
Thanks @adityadeshpande09! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1428
Changes:
On clicking link it redirects to the :
https://github.com/processing/p5.js-website/blob/main/contributor_docs/i18n_contribution.md page instead of error 404.
Screenshots of the change:
