Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: check text annotation defined in the collaboration node #3191

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

tbouffard
Copy link
Member

@tbouffard tbouffard commented Oct 18, 2024

Overview

We currently only support text annotation defined in process or subprocess.
Add a visual test to demonstrate that, for now, a text annotation (and its related association) is not rendered when it is defined in the "collaboration" node in the XML diagram.
In the BPMN diagram used in the test, there are some text annotations defined in the "collaboration" that are linked to elements of a process. So they are not displayed. Such modeling comes from the demo bpmn-js and demonstrates that the limitation doesn't only apply to text annotation related to pools.

Notes

Covers #2635

bpmn-visualization (from visual tests) bpmn-js
associations and annotations 06 defined in collaboration bpmn_text-annotation_collaboration_2024-10-18_06-41-02

@tbouffard tbouffard added the chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...) label Oct 18, 2024
Copy link

sonarcloud bot commented Oct 18, 2024

@tbouffard tbouffard marked this pull request as ready for review October 18, 2024 12:40
@tbouffard tbouffard merged commit 5eb95d2 into master Oct 21, 2024
20 checks passed
@tbouffard tbouffard deleted the test/bpmn_artifact_in_collaboration_node branch October 21, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants