Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: add labels automatically on PR creation or update #3187

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ci: add labels automatically on PR creation or update #3187

wants to merge 1 commit into from

Conversation

csouchet
Copy link
Member

@csouchet csouchet commented Oct 8, 2024

  • Add step on workflow of metadata PR checking, to add labels
  • Add labeler config

@csouchet csouchet added the github_actions Pull requests that update Github_actions code label Oct 8, 2024
@csouchet
- Add labeler config
031c255 
- Add step on workflow of metadata PR checking, to add labels
@csouchet csouchet marked this pull request as ready for review October 8, 2024 15:44
@tbouffard
Copy link
Member

tbouffard commented Oct 8, 2024 •
edited
Loading

I'm not currently convinced about using this automation.
It's going to be difficult to maintain, the files are sometimes modified for purposes other than what is configured and so we'll have to delete the tags in some cases, which will represent additional maintenance.
It also adds to the load on GH Actions.

Isn't it possible to configure only the branch name? That would simplify maintenance.
We should also probably review our Contributing guide as the recommended branch name doesn't follow the patterns proposed in the labeler configuration.

I've known about the labeler action for a while and haven't seen a project where it was useful on PR. Do you have any examples to share where you've seen value in adding such automation?

Can we discuss this in person?

tbouffard
tbouffard reviewed Oct 8, 2024
View reviewed changes
.github/labeler.yml
- head-branch: ['^fix/']

# Add 'build' label to any PR where the head branch name starts with `build/`
build:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have such a label

.github/labeler.yml
- 'vite.config.js'

# Add 'ci' label to any PR where the head branch name starts with `ci/`
github_actions:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This label is currently used to identify bump of gh actions only. PR related to CI changes are labeled with "core".
Labels are used to generate the release notes and until now, we didn't consider to split CI changes from other "chore" changes

.github/labeler.yml
- '.github/**/*' # Any change to files within '.github' folder or any subfolders

# Add 'defect' label to any PR where the head branch name starts with `defect/`
defect:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have such a label

@tbouffard tbouffard added chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...) and removed github_actions Pull requests that update Github_actions code labels Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbouffard tbouffard tbouffard left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@csouchet @tbouffard