Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix notification workflows used during releases #3157

Merged
merged 4 commits into from
Aug 30, 2024

Conversation

tbouffard
Copy link
Member

@tbouffard tbouffard commented Aug 30, 2024

The event send by the "npm publish" workflow was incorrect, it didn't correctly integrate the configuration tested in the playground repository.
The workflow notifying the R package included 2 issues

  • the internal action wasn't checkout
  • the name of the target repository contained a typo

The problems above have impacted the release of version 0.44.0.
Running the fixed workflow manually fixed the problems for this particular release.

Notes

#3156 didn't provide a complete solution.

Problems detected during the 0.44.0 release:

R package

Run with workflow_dispatch with the branch of this PR

❌ Commit: 35b6dfc failed

https://github.com/process-analytics/bpmn-visualization-js/actions/runs/10630529613/job/29469577907

Run peter-evans/repository-dispatch@v3
  with:
    token: ***
    repository: process-analytics/bpmn-visualization-R'
    event-type: update_bpmn_visualization_version
    client-payload: {"version":"0.44.0"}
  env:
    VERSION: 0.44.0
    CLIENT_PAYLOAD: {"version":"0.44.0"}
Error: Repository not found, OR token has insufficient permissions.

There is an extra quote at the end of the name of the repository: process-analytics/bpmn-visualization-R'
Seen in the URL of the endpoint used when running the job in debug https://github.com/process-analytics/bpmn-visualization-js/actions/runs/10630529613/job/29470436154

https://api.github.com/repos/process-analytics/bpmn-visualization-R%27/dispatches',

✔️ Commit 974e1a6 succeeded

The PR was created successfully: process-analytics/bpmn-visualization-R#281
https://github.com/process-analytics/bpmn-visualization-js/actions/runs/10633555566/job/29478864552

Run peter-evans/repository-dispatch@v3
  with:
    token: ***
    repository: process-analytics/bpmn-visualization-R
    event-type: update_bpmn_visualization_version
    client-payload: {"version":"0.44.0"}
  env:
    VERSION: 0.44.0
    CLIENT_PAYLOAD: {"version":"0.44.0"}

Repository of examples

Run manually from the master branch, using version 0.44.0, https://github.com/process-analytics/bpmn-visualization-js/actions/runs/10630742335/job/29470243002
The PR was created successfully: process-analytics/bpmn-visualization-examples#599

@tbouffard tbouffard added the chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...) label Aug 30, 2024
@tbouffard tbouffard marked this pull request as ready for review August 30, 2024 13:35
@tbouffard tbouffard merged commit 6dca528 into master Aug 30, 2024
3 checks passed
@tbouffard tbouffard deleted the ci/fix_release_notif_wf branch August 30, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants