Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: [POC] Replace mxGraph with maxGraph 0.10.x #3098

Draft
wants to merge 90 commits into
base: master
Choose a base branch
from

Commits on Jul 4, 2023

  1. POC maxGraph 0.1.0 v1

    tbouffard committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    9083c7d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2909669 View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2024

  1. POC maxGraph 0.1.0 v2

    BpmnGraph: remove batchUpdate as it is already defined in the Graph class
    
    GraphCellUpdater.ts: WIP fix TSC errors
    
    StyleManager.ts: WIP fix TSC errors
    
    StyleComputer.ts: WIP fix TSC errors
    
    BpmnRenderer.ts: update TODO
    
    StyleConfigurator.ts: WIP fix TSC errors
    
    StyleConfigurator.ts: add TODO after rebase
    
    ShapeConfigurator.ts: WIP fix TSC errors
    
    fix rebase: fix FONT imports (no more exported in style/index - internal only)
    
    Add TODO in BPMNCellStyle
    
    style/utils.ts: WIP fix TSC errors
    
    StyleManager.ts: remove unused imports
    
    StyleComputer.test.ts: WIP fix TSC errors
    
    integration tests: WIP fix TSC errors
    
    mxGraph.model.bpmn.elements.test.ts: restore variable name after rebase (no mx in names)
    
    run fix CSS class undefined access - WIP CSS classes disapaer when doing navigation
    
    fix typo in TODO/FIXME about maxgraph
    
    StyleComputer.test.ts: fix msg flow icon tests after rebase
    
    StyleComputer.test.ts: fix sub-process tests after rebase
    
    StyleComputer.test.ts: clean comment in sub-process tests after rebase
    
    the comments was the test implementation in the previous poc. During rebase, as there were too many conflicts, the tests
     hadn't been migrated and the former poc implem put there to help the new test migration
    
    StyleComputer.test.ts: fix subprocess markers test
    
    StyleComputer.test.ts: fix event gateway test
    
    StyleComputer.test.ts: WIP fix bpmn in color
    
    StyleComputer.ts: fix msg icon flow extension computation
    
    StyleComputer.ts: improve comment
    
    StyleComputer.ts: fix edges extension computation
    
    style-utils.test.ts: fix subprocess tests (adhoc still KO)
    
    style-utils.test.ts: fix msg flow icon
    
    style-utils.test.ts: FIXME for adhoc
    
    ThemedBpmnVisualization.ts: fix wrongly migrated comment
    
    refactor: restore getDataModel method when getModel was called with mxGraph
    
    refactor: restore usage of getDataModel method in BpmnRenderer.ts
    
    refactor: restore usage of getDataModel method in GraphCellUpdater.ts
    
    GraphCellUpdater.ts add TODO for the master branch
    
    SvgExporter.ts: restore import order like with mxGraph imple
    
    ShapeConfigurator.ts: restore import order like with mxGraph implem
    
    ShapeConfigurator.ts: restore comment
    
    StyleConfigurator.ts: restore import order
    
    StyleConfigurator.ts: add todo for arc configuration
    
    custom-overlay.ts: restore import order
    
    toBeShape/index.ts: fix compilation errors
    
    toBeEdge/index.ts: fix compilation errors
    
    matcher-utils.ts: fix compilation errors
    
    mxGraph.model.bpmn.elements.test.ts: fix compilation errors
    
    integration tests: fix CSS api tests
    
    mxGraph.model.css.api.test.ts: check no extra css classes prior adding them
    
    IT: simplify check of extra css classes edge/shape
    
    WIP debug extra CSS classes not added to the dom
    
    style-utils.test.ts: fix test
    
    WIP restore style.isInitiating: make test pass
    
    WIP restore style.isInitiating
    
    integration test: BpmnCellStyle.horizontal is now a boolean (same type as in CellStyle)
    
    integration test: fix test in "bpmn in color"
    
    StyleComputer.ts remove TODO about "isInitiating" (already managed)
    
    mxGraph.model.bpmn.elements.test.ts: revert extra changes
    
    StyleComputer.ts remove TODO about "style.horizontal" (already managed)
    
    StyleComputer.ts fix label position (horizontal and vertical)
    
    style-utils.test.ts: remove TODO already managed
    
    StyleComputer.ts: simplify management of style.horizontal for lane and pool
    
    update TODO
    
    custom-overlay.ts: restore original license header
    
    model-expect.ts: remove extra imports
    
    model-expect.ts: simplify import
    
    WIP tmp fix to update the style
    
    WIP tmp fix to update the style and CSS classes (clone the style of the cell to cache and update)
    
    refactor: simply the storage of CSS classes in the BPMN style object
    
    integ test: refactor markers management
    
    integ test: restore the implem of the getFontStyleValue utils function (make 2 tests pass)
    
    CSS classes: only set in style when the array is not empty (fix 10 integration tests)
    
    TMP: more logs in the matcher error msg to better diagnose the problem
    
    WIP integ test: investigate lower fontStyle value
    
    WIP integ test: fix fontStyle value
    
    update TODO comments for consistency
    
    fix more integration tests: CSS class reset
    
    fix wrong assertion in IT: fontStyle
    
    updateStyle fontStyle: less side effect when setting flag of undefined value
    
    StyleComputer: do not set fontStyle value to 0 (restore mxGraph behaviour) + fix IT
    
    IT: remove extra check
    
    fix: updateStyle 'default' special value now correctly reset the value
    
    style utils.ts: improve TODO
    
    improve comments about workarounds for maxGraph issues
    
    Add TODO set plugins in Graph constructor
    
    mxGraph.model.style.api.test.ts remove extra FIXME
    
    mxGraph.model.style.api.test.ts add TODO
    
    StyleComputer.ts remove managed TODO
    
    style utils: update todo
    
    test: simplify todo
    
    remove managed TODO
    
    matcher-utils.ts: remove tmp solution to jest msg
    
    matcher-utils.ts remove managed TODO
    
    Manage "todo rebase"
    
    update todo
    
    fix style for rounded activity (was not correcly migrated)
    
    StyleConfigurator.ts: migrated code better fit the original code
    
    manage some "todo rebase"
    
    refactor: style function - no need to return the style object anymore
    
    refactor: rename style properties used to fill markers (prepare future feature available in maxGraph)
    
    Add todo about fixing "fill edge markers"
    tbouffard committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    8f4ee05 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f6681a1 View commit details
    Browse the repository at this point in the history
  3. update package-lock.json

    tbouffard committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    f3b1775 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    db2a32a View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    b8df3cc View commit details
    Browse the repository at this point in the history
  6. update package-lock.json

    tbouffard committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    bb5b140 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    cdced05 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2024

  1. Configuration menu
    Copy the full SHA
    675857d View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2024

  1. EXTRA integration tests run in ESM (needed for maxgraph --> IN PROGRE…

    …SS in master branch)
    
    WIP integration tests run in ESM (with commonJS configuration)
    
    Revert "EXTRA WIP run integration in ESM mode"
    
    This reverts commit 21c3691647630cd11f5572789d47cc5a22decfce.
    
    EXTRA WIP run integration in ESM mode
    
    EXTRA WIP run integration in ESM mode (vscode config)
    tbouffard committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    fc62054 View commit details
    Browse the repository at this point in the history
  2. EXTRA unit tests run in ESM (needed to run maxgraph)

    with commonJS configuration
    
    EXTRA WIP unit tests run in ESM (with commonJS configuration)
    
    WIP unit tests run in ESM (with commonJS configuration)
    
    WIP unit tests run in ESM (with commonJS configuration) test pass
    
    WIP unit tests run in ESM (with commonJS configuration) vscode config
    tbouffard committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    1aa5ee2 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d6d2261 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    d6420fb View commit details
    Browse the repository at this point in the history
  5. EXTRA jest.image.ts fix async by using await

    The promises management was wrong, images were not correctly assigned to the right file
    tbouffard committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    e3af056 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    c925966 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    c95a9cb View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    54e8117 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    b002dcd View commit details
    Browse the repository at this point in the history
  10. bump maxGraph

    tbouffard committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    99901fa View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    ec2b544 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    2286241 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    a6b3f2a View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    7ae90a5 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    f340246 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    6f2f057 View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2024

  1. Configuration menu
    Copy the full SHA
    2c5726d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d208c48 View commit details
    Browse the repository at this point in the history
  3. StyleManager update TODO

    tbouffard committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    21f6694 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    82ce011 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    8024887 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    a6fc85b View commit details
    Browse the repository at this point in the history
  7. StyleComputer.ts BPMNCellStyle remove arrow fill properties available…

    … out of the box in maxGraph
    tbouffard committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    221aac3 View commit details
    Browse the repository at this point in the history
  8. Add TODO

    tbouffard committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    bcd1f7e View commit details
    Browse the repository at this point in the history
  9. fix TODO

    tbouffard committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    3ea1a7e View commit details
    Browse the repository at this point in the history
  10. update TODO in BpmnGraph.ts

    tbouffard committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    827f436 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    f91d847 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    b6a14e1 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    14ab375 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    cacc7f5 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    a4e6ffc View commit details
    Browse the repository at this point in the history
  16. Update TODO

    tbouffard committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    eff4a53 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    628a6d8 View commit details
    Browse the repository at this point in the history
  18. StyleComputer.ts: fix TODO

    tbouffard committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    af351af View commit details
    Browse the repository at this point in the history
  19. remove extra imports

    tbouffard committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    88a6524 View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    dc396e0 View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    927ce24 View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    79ea060 View commit details
    Browse the repository at this point in the history
  23. style-utils.ts manage TODO

    tbouffard committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    e37b321 View commit details
    Browse the repository at this point in the history
  24. Configuration menu
    Copy the full SHA
    65c4935 View commit details
    Browse the repository at this point in the history
  25. Configuration menu
    Copy the full SHA
    a36015a View commit details
    Browse the repository at this point in the history
  26. Configuration menu
    Copy the full SHA
    53197c3 View commit details
    Browse the repository at this point in the history
  27. Configuration menu
    Copy the full SHA
    d72d568 View commit details
    Browse the repository at this point in the history
  28. Configuration menu
    Copy the full SHA
    bdea858 View commit details
    Browse the repository at this point in the history
  29. Configuration menu
    Copy the full SHA
    0ccbc64 View commit details
    Browse the repository at this point in the history
  30. test: Remove "align" types and use maxGraph "align" type instead (the…

    …y are used to define related maxGraph properties)
    tbouffard committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    c7e5142 View commit details
    Browse the repository at this point in the history
  31. Configuration menu
    Copy the full SHA
    e5b5fa2 View commit details
    Browse the repository at this point in the history
  32. Configuration menu
    Copy the full SHA
    643bf1a View commit details
    Browse the repository at this point in the history
  33. Configuration menu
    Copy the full SHA
    797c9f4 View commit details
    Browse the repository at this point in the history
  34. Configuration menu
    Copy the full SHA
    242fe00 View commit details
    Browse the repository at this point in the history
  35. bump maxGraph to 0.10.2

    tbouffard committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    5894e10 View commit details
    Browse the repository at this point in the history
  36. Configuration menu
    Copy the full SHA
    284905a View commit details
    Browse the repository at this point in the history
  37. SVGExporter: manage TODO

    tbouffard committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    c286c77 View commit details
    Browse the repository at this point in the history
  38. Configuration menu
    Copy the full SHA
    7fc8e9d View commit details
    Browse the repository at this point in the history
  39. Configuration menu
    Copy the full SHA
    a4bade6 View commit details
    Browse the repository at this point in the history
  40. Configuration menu
    Copy the full SHA
    087bf5c View commit details
    Browse the repository at this point in the history
  41. Configuration menu
    Copy the full SHA
    e7b8f89 View commit details
    Browse the repository at this point in the history
  42. Configuration menu
    Copy the full SHA
    3ca3cd0 View commit details
    Browse the repository at this point in the history
  43. Configuration menu
    Copy the full SHA
    5930261 View commit details
    Browse the repository at this point in the history
  44. Configuration menu
    Copy the full SHA
    9672809 View commit details
    Browse the repository at this point in the history
  45. Configuration menu
    Copy the full SHA
    39d2e31 View commit details
    Browse the repository at this point in the history
  46. Configuration menu
    Copy the full SHA
    ff1e1cf View commit details
    Browse the repository at this point in the history
  47. Configuration menu
    Copy the full SHA
    84f62b2 View commit details
    Browse the repository at this point in the history
  48. Configuration menu
    Copy the full SHA
    ca48e96 View commit details
    Browse the repository at this point in the history
  49. Configuration menu
    Copy the full SHA
    f265908 View commit details
    Browse the repository at this point in the history
  50. Configuration menu
    Copy the full SHA
    61bd589 View commit details
    Browse the repository at this point in the history
  51. WIP remove maxGraph workaround for v0.1.0 that are now fixed - BpmnGr…

    …aph.ts: remove unused imports
    tbouffard committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    e2e6f76 View commit details
    Browse the repository at this point in the history
  52. Configuration menu
    Copy the full SHA
    3924d31 View commit details
    Browse the repository at this point in the history
  53. Configuration menu
    Copy the full SHA
    67a7b5b View commit details
    Browse the repository at this point in the history
  54. types.ts: update TODO

    tbouffard committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    227c849 View commit details
    Browse the repository at this point in the history
  55. BpmnGraph.ts update TODO

    tbouffard committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    d993029 View commit details
    Browse the repository at this point in the history
  56. Configuration menu
    Copy the full SHA
    4e2bba3 View commit details
    Browse the repository at this point in the history
  57. Configuration menu
    Copy the full SHA
    8e18141 View commit details
    Browse the repository at this point in the history
  58. Configuration menu
    Copy the full SHA
    34553da View commit details
    Browse the repository at this point in the history
  59. Configuration menu
    Copy the full SHA
    db7e4a2 View commit details
    Browse the repository at this point in the history
  60. Configuration menu
    Copy the full SHA
    2de8548 View commit details
    Browse the repository at this point in the history
  61. Configuration menu
    Copy the full SHA
    16768c2 View commit details
    Browse the repository at this point in the history
  62. Configuration menu
    Copy the full SHA
    e10cecd View commit details
    Browse the repository at this point in the history
  63. Configuration menu
    Copy the full SHA
    da64089 View commit details
    Browse the repository at this point in the history
  64. Configuration menu
    Copy the full SHA
    f50b06e View commit details
    Browse the repository at this point in the history