Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove extra spacing between 2 activity markers #3052

Merged
merged 2 commits into from
Mar 7, 2024

Commits on Mar 6, 2024

  1. fix: remove extra spacing between 2 activity markers

    When there are 2 markers, the center was translated/shifted too much.
    We assume that the width value of markers is `SHAPE_ACTIVITY_MARKER_ICON_SIZE`.
    We want to have a spacing value between the 2 markers of `SHAPE_ACTIVITY_MARKER_ICON_MARGIN`.
    
    To have 2 markers horizontally centered and closed to each other, we need to translate the first marker to the left and
    the second to the right by half the value of the marker width.
    To add a space between the 2 markers, we need to translate both markers by half the value of the global "spacing value".
    Previously, the translation value included the full marker width which is too much.
    
    Also include refactoring:
      - Use more accurate name for the parameters of `getMarkerIconOriginFunction`.
    tbouffard committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    4d8426d View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2024

  1. Configuration menu
    Copy the full SHA
    14b68ef View commit details
    Browse the repository at this point in the history