Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: enforce no unused parameters and locals with TypeScript #3051

Merged
merged 4 commits into from
Mar 7, 2024
Merged

chore: enforce no unused parameters and locals with TypeScript #3051

merged 4 commits into from
Mar 7, 2024

Commits on Mar 6, 2024

  1. chore: enforce no unused parameters and locals with TypeScript 

    Fix new TS compiler errors: remove or prefix (when must be kept to override methods) parameters, remove unused class
properties.
Group "noXXX" TypeScript compiler options.
    @tbouffard
    tbouffard committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    8a209b4 View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2024

  1. Merge branch 'master' into refactor/enforce_no_unused_params_var_with… 

    …_tsc
    @tbouffard
    tbouffard committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    a701346 View commit details
    Browse the repository at this point in the history

  2. e2e jest config: remove extra param

    @tbouffard
    tbouffard committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    090b00c View commit details
    Browse the repository at this point in the history

  3. unit test: fix some tsc errors 

    Mark unused param in test function. They must be kept as the parameter is used to generate the test title or because it
is required by the function signature.
    @tbouffard
    tbouffard committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    f2e84d9 View commit details
    Browse the repository at this point in the history