test(JsonBuilder): add new properties for link events #2895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csouchet
added
the
chore
csouchet
force-pushed
the
2855-update_test_helper_JsonBuilder
branch
3 times, most recently
from
e6d431a
to
4e2d032
Compare
csouchet
added
the
depends on another PR ⚠️
csouchet
force-pushed
the
2855-update_test_helper_JsonBuilder
branch
from
4e2d032
to
ad246a9
Compare
csouchet
changed the title
csouchet
force-pushed
the
2855-update_test_helper_JsonBuilder
branch
4 times, most recently
from
3698f33
to
64aee24
Compare
csouchet
changed the title
- source: for Link Intermediate Catch Event - target: for Link Intermediate Throw Event
csouchet
force-pushed
the
2855-update_test_helper_JsonBuilder
branch
from
64aee24
to
7f88cbc
Compare
csouchet
removed
the
depends on another PR ⚠️
tbouffard
approved these changes
Oct 3, 2023
|
|
||
| export type BuildEventsParameter = BuildOtherEventParameter | BuildStartEventParameter | BuildBoundaryEventParameter; | ||
| export type BuildEventParameter = BuildNotBoundaryEventParameter | BuildBoundaryEventParameter; | ||
| export type BuildNotBoundaryEventParameter = BuildIntermediateCatchEventParameter | BuildIntermediateThrowEventParameter | BuildEndEventParameter | BuildStartEventParameter; |
There was a problem hiding this comment.
question: can we found a better name than BuildNotBoundaryEventParameterthat doesn't use a negation? Does it means "all kind of events but the boundary events"?
There was a problem hiding this comment.
Yes, indeed, it's all events excepted boundary. I didn't find better name, and the old (BuildOtherEventParameter) wasn't better.
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Update the test helper
JsonBuilderto set the properties:source: for Link event definition of Intermediate Catch Eventtarget: for Link event definition of Intermediate Throw EventAnd rename some existing types.
Covers #2906