-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use the new flow/flownode links from the bpmn semantic in the predictions demo #515
refactor: use the new flow/flownode links from the bpmn semantic in the predictions demo #515
Conversation
7520111
to
f973d9a
Compare
I cannot review this PR until #514 is merged. There are commits coming from the dependent PRs and new commits in this one. |
f973d9a
to
3884708
Compare
…he_BPMN_Semantic_in_the__Predictions__demo
@@ -0,0 +1,43 @@ | |||
// From Bonita Day 2023 Demo | |||
class PathResolver { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue: we cannot duplicate the code from the demo.
We already know it requires refactoring at least for process-analytics/bonita-day-demo-2023#52. There are also a lot of extra validation of the incoming/outgoing (verification that a related edge id exists in the model) whereas this should be guarantee by bpmn-visualization.
In addition, we plan to extract PathResolver from the bonita day demo process-analytics/bonita-day-demo-2023#36. If we duplicate the implementation here, we must track it and plan to use the shared code here. And this may not possible out of the box depending on the way we package the shared code. In particular, we are not sure to to provide an IIFE bundle for the shared lib.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To replace in another PR. See #260
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's talk about alternatives to the code duplicated from the bonita day demo (PathResolver).
As I mentioned in #514 (review), it's becoming increasingly clear to me that we should consider moving this demo to its own repository to benefit from the package manager, the shared library and the framework.
…he_BPMN_Semantic_in_the__Predictions__demo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Live environment of examples
https://cdn.statically.io/gh/process-analytics/bpmn-visualization-examples/476-Use_the_new_flow/flownode_links_from_the_BPMN_Semantic_in_the__Predictions__demo/demo/predictions/index.html
last commit: https://cdn.statically.io/gh/process-analytics/bpmn-visualization-examples/2eebd856f88103797eabea27035cc309e23f2d6a/demo/predictions/index.html
Closes #476